RESOLVED FIXED 109906
Web Inspector: Introduce ProfilesPanelDescriptor. 
https://bugs.webkit.org/show_bug.cgi?id=109906
Summary Web Inspector: Introduce ProfilesPanelDescriptor.
Eugene Klyuchnikov
Reported 2013-02-15 00:15:59 PST
Some constants/methods should be accessible before ProfilePanel is instantiated.
Attachments
Patch (18.25 KB, patch)
2013-02-15 00:37 PST, Eugene Klyuchnikov 		pfeldman: review+
DetailsFormatted DiffDiff
Patch (17.67 KB, patch)
2013-02-17 23:38 PST, Eugene Klyuchnikov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-02-15 00:37:38 PST
Created attachment 188499 [details] Patch
Pavel Feldman
Comment 2 2013-02-15 06:09:37 PST
Comment on attachment 188499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review > Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50 > +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) { Move { to the next line. > Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59 > +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) { ditto
Eugene Klyuchnikov
Comment 3 2013-02-17 23:38:36 PST
Created attachment 188803 [details] Patch
Eugene Klyuchnikov
Comment 4 2013-02-17 23:40:18 PST
Comment on attachment 188499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188499&action=review >> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:50 >> +WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile = function(title) { > > Move { to the next line. Done >> Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js:59 >> +WebInspector.ProfilesPanelDescriptor.userInitiatedProfileIndex = function(title) { > > ditto Done
WebKit Review Bot
Comment 5 2013-02-17 23:43:14 PST
Comment on attachment 188803 [details] Patch Rejecting attachment 188803 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 188803, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16611092
Eugene Klyuchnikov
Comment 6 2013-02-17 23:53:51 PST
Committed r143159: <http://trac.webkit.org/changeset/143159>
Note You need to log in before you can comment on or make changes to this bug.