Currently likifier plugin is a function that translates link title. This way we have logic about linkified links spread in several files. This patch turns linkier plugin to interface responsible for checking URL, title translation and URL navigation.
Created attachment 188279 [details] Patch
Comment on attachment 188279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188279&action=review > Source/WebCore/ChangeLog:12 > + This patch turns linkier plugin to interface responsible for checking linkifier > Source/WebCore/inspector/front-end/ProfilesPanel.js:788 > + showProfile: function(typeId, title, uid) title is not used. > Source/WebCore/inspector/front-end/ResourceUtils.js:56 > +WebInspector.ProfileURLRegExp = /webkit-profile:\/\/(.+)\/(.+)#([0-9]+)/; ResourceUtils should know nothing about the profiler.
Created attachment 189010 [details] Patch
Comment on attachment 189010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189010&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:653 > - showProfile: function(profile) > + showProfile_: function(profile) The underscore should be a prefix not a suffix.
Created attachment 189021 [details] Patch
Comment on attachment 189010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189010&action=review >> Source/WebCore/inspector/front-end/ProfilesPanel.js:653 >> + showProfile_: function(profile) > > The underscore should be a prefix not a suffix. Fixed.
Comment on attachment 189021 [details] Patch Attachment 189021 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16653237 New failing tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html inspector/profiler/cpu-profiler-profiling.html inspector/profiler/heap-snapshot-summary-show-all.html inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-summary-retainers.html animations/suspend-resume-animation-events.html inspector/audits/audits-panel-functional.html fast/loader/text-document-wrapping.html inspector/profiler/heap-snapshot-comparison-sorting.html inspector/profiler/heap-snapshot-dominators-show-all.html inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-show-next.html inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html inspector/profiler/heap-snapshot-comparison-show-next.html inspector/profiler/heap-snapshot-comparison-show-all.html inspector/profiler/canvas2d/canvas-replay-log-grid.html inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html inspector/profiler/heap-snapshot-dominators-sorting.html inspector/profiler/heap-snapshot-reveal-in-dominators-view.html fast/table/border-collapsing/cached-69296.html inspector/profiler/heap-snapshot-comparison-dom-groups-change.html inspector/profiler/heap-snapshot-loader.html inspector/profiler/heap-snapshot-containment-sorting.html inspector/profiler/heap-snapshot-containment-show-all.html inspector/profiler/heap-snapshot-containment-show-next.html inspector/profiler/heap-snapshot-summary-show-next.html inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html fast/loader/javascript-url-in-object.html inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
Created attachment 189322 [details] Patch fixed-tests
Committed r143580: <http://trac.webkit.org/changeset/143580>
@eustas: plz look at what you have committed: http://trac.webkit.org/changeset/143580/trunk/Source/WebCore/inspector/Inspector.json I'll fix it.
(In reply to comment #10) > @eustas: plz look at what you have committed: http://trac.webkit.org/changeset/143580/trunk/Source/WebCore/inspector/Inspector.json > > I'll fix it. Partial roll out: http://trac.webkit.org/changeset/143603