Bug 109871 – [Chromium] REGRESSION: Closed Captions button not showing properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Victor Carbune]

I'm not sure when this actually broke, but the CC button isn't displayed anymore,
though the button exists there (probably the resource isn't painted for some reason?)

It might not be Chromium specific, so if it happens on other ports I'll rename it.

The two pixel tests that would have caught this were marked as requiring
new baselines after webkit.org/b/97800 (but this clearly isn't the cause of the bug)

[Victor Carbune]

Created attachment 188444 [details]
Screenshot

[Christian Biesinger]

The two tests are
LayoutTests/media/track/track-cue-rendering-horizontal.html
LayoutTests/media/track/track-cue-rendering-vertical.html

I tried to look at them in my Chromium browser, but I can't get any CC-related things to show up (not even the button that doesn't quite display). Am I doing it wrong?

[Christian Biesinger]

Oh, figured it out. Need to load this via SimpleHTTPServer to work.

[Silvia Pfeiffer]

I have a patch coming up for this (preparing test expectations now) - I honestly have no idea how that button ever showed up! ;-)

[Silvia Pfeiffer]

Created attachment 188965 [details]
get Linux testexpectations

[WebKit Review Bot]

Comment on attachment 188965 [details]
get Linux testexpectations

Attachment 188965 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16615432

New failing tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

[Christian Biesinger]

Hm... should the new .pngs be in that diff too?

[Silvia Pfeiffer]

This is a regression - the images for the caption button have been committed before.

[Christian Biesinger]

Well bug 109775 regenerated those PNGs (because the time slider is now slightly different), so the PNGs do need to be regenerated... this is why the cr-linux bot is red for this patch.

[Silvia Pfeiffer]

Oh, the test expectations! Sure! I was expecting them to be attached to the bot failure report. (They used to be.) Gotta create them differently now. This wasn't for landing!

[Christian Biesinger]

Oh! Heh. Sorry for being unclear!

[Silvia Pfeiffer]

Created attachment 190191 [details]
Patch

[Silvia Pfeiffer]

Note: checked the images on mountain lion - need to create rebaseline test expectation images after landing

[Silvia Pfeiffer]

review ping?

[Silvia Pfeiffer]

Created attachment 192402 [details]
remainder patch

[WebKit Review Bot]

Comment on attachment 192402 [details]
remainder patch

Rejecting attachment 192402 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Silvia Pfeiffer]

Comment on attachment 192402 [details]
remainder patch

Just landed my committer rights, trying to land again.

[WebKit Review Bot]

Comment on attachment 192402 [details]
remainder patch

Rejecting attachment 192402 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Build Bot]

Comment on attachment 192402 [details]
remainder patch

Attachment 192402 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17121076

New failing tests:
editing/selection/selection-modify-crash.html

[Silvia Pfeiffer]

Comment on attachment 192402 [details]
remainder patch

Try again - hopefully I'm now in the committers.py file.

[WebKit Review Bot]

Comment on attachment 192402 [details]
remainder patch

Clearing flags on attachment: 192402

Committed r145347: <http://trac.webkit.org/changeset/145347>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.