Bug 109654 – [WK2] Remove web intents callbacks

• Status: REOPENED
• Component: WebKit2

[Gyuyoung Kim]

Though web intent feature isn't supported anymore, some web intent callbacks aren't removed yet.

[Gyuyoung Kim]

Created attachment 187998 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187998 [details]
Patch

Attachment 187998 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16483576

[Gyuyoung Kim]

Created attachment 188001 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Early Warning System Bot]

Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16520550

[EFL EWS Bot]

Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16520567

[Benjamin Poulain]

Comment on attachment 188001 [details]
Patch

This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion.

Please test thoroughly on Mac though.

[Gyuyoung Kim]

(In reply to comment #7)
> (From update of attachment 188001 [details])
> This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion.
> 
> Please test thoroughly on Mac though.

Sure, I will land this patch after checking on efl, qt and mac. Thanks.

[Build Bot]

Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16522638

[Gyuyoung Kim]

Created attachment 188029 [details]
Patch for ews

[WebKit Review Bot]

Comment on attachment 188029 [details]
Patch for ews

Clearing flags on attachment: 188029

Committed r142736: <http://trac.webkit.org/changeset/142736>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 109716

[Alexey Proskuryakov]

It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries.

[Anders Carlsson]

(In reply to comment #14)
> It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries.

(which i did when I removed web intents from WebKit2).

[Benjamin Poulain]

Didn't I ask you to verify bin compat on Mac? :(

[Gyuyoung Kim]

(In reply to comment #16)
> Didn't I ask you to verify bin compat on Mac? :(

I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here.

[Anders Carlsson]

(In reply to comment #17)
> (In reply to comment #16)
> > Didn't I ask you to verify bin compat on Mac? :(
> 
> I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here.

We need to keep the dummy callback around so that nightly builds of WebKit still work with the latest version of Safari shipped.