Bug 109654 - [WK2] Remove web intents callbacks
Summary: [WK2] Remove web intents callbacks
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 109716
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-12 20:36 PST by Gyuyoung Kim
Modified: 2013-10-02 12:28 PDT (History)
13 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2013-02-12 20:38 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (8.60 KB, patch)
2013-02-12 21:03 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for ews (10.04 KB, patch)
2013-02-13 00:48 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-02-12 20:36:16 PST
Though web intent feature isn't supported anymore, some web intent callbacks aren't removed yet.
Comment 1 Gyuyoung Kim 2013-02-12 20:38:00 PST
Created attachment 187998 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-12 20:54:10 PST
Comment on attachment 187998 [details]
Patch

Attachment 187998 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16483576
Comment 3 Gyuyoung Kim 2013-02-12 21:03:07 PST
Created attachment 188001 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-12 21:06:03 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 Early Warning System Bot 2013-02-12 21:13:16 PST
Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16520550
Comment 6 EFL EWS Bot 2013-02-12 21:44:05 PST
Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16520567
Comment 7 Benjamin Poulain 2013-02-12 22:19:29 PST
Comment on attachment 188001 [details]
Patch

This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion.

Please test thoroughly on Mac though.
Comment 8 Gyuyoung Kim 2013-02-12 22:37:28 PST
(In reply to comment #7)
> (From update of attachment 188001 [details])
> This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion.
> 
> Please test thoroughly on Mac though.

Sure, I will land this patch after checking on efl, qt and mac. Thanks.
Comment 9 Build Bot 2013-02-12 23:49:56 PST
Comment on attachment 188001 [details]
Patch

Attachment 188001 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16522638
Comment 10 Gyuyoung Kim 2013-02-13 00:48:27 PST
Created attachment 188029 [details]
Patch for ews
Comment 11 WebKit Review Bot 2013-02-13 04:01:28 PST
Comment on attachment 188029 [details]
Patch for ews

Clearing flags on attachment: 188029

Committed r142736: <http://trac.webkit.org/changeset/142736>
Comment 12 WebKit Review Bot 2013-02-13 04:01:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 13 WebKit Review Bot 2013-02-13 10:47:34 PST
Re-opened since this is blocked by bug 109716
Comment 14 Alexey Proskuryakov 2013-02-13 10:55:19 PST
It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries.
Comment 15 Anders Carlsson 2013-02-13 11:08:42 PST
(In reply to comment #14)
> It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries.

(which i did when I removed web intents from WebKit2).
Comment 16 Benjamin Poulain 2013-02-13 11:39:09 PST
Didn't I ask you to verify bin compat on Mac? :(
Comment 17 Gyuyoung Kim 2013-02-13 17:27:39 PST
(In reply to comment #16)
> Didn't I ask you to verify bin compat on Mac? :(

I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here.
Comment 18 Anders Carlsson 2013-02-13 17:31:14 PST
(In reply to comment #17)
> (In reply to comment #16)
> > Didn't I ask you to verify bin compat on Mac? :(
> 
> I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here.

We need to keep the dummy callback around so that nightly builds of WebKit still work with the latest version of Safari shipped.