Bug 109593 - [GTK] Remove support for compiling with GStreamer 0.10
Summary: [GTK] Remove support for compiling with GStreamer 0.10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 109734
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-12 09:30 PST by Martin Robinson
Modified: 2013-02-14 06:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.39 KB, patch)
2013-02-12 13:42 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-02-12 09:30:50 PST
We are about to commit to supporting dependencies until WebKitGTK+ 3.0, so we need to remove dependencies that we don't want to support that long.
Comment 1 Philippe Normand 2013-02-12 09:34:35 PST
You mean the configure.ac bits I guess?
Comment 2 Martin Robinson 2013-02-12 09:35:05 PST
Yep. The code will stay. I've got a patch cooking locally.
Comment 3 Martin Robinson 2013-02-12 13:42:36 PST
Created attachment 187923 [details]
Patch
Comment 4 Philippe Normand 2013-02-12 23:29:55 PST
So, while I agree with the rationale, this won't help us maintain the 0.10 code until gst 1.2 is fixed and we can drop the 0.10 support all together :(

Maybe we can take a less extreme approach for now? Issue an error is configure is called with --with-gstreamer=0.10 ?
Comment 5 WebKit Review Bot 2013-02-13 09:26:18 PST
Comment on attachment 187923 [details]
Patch

Clearing flags on attachment: 187923

Committed r142756: <http://trac.webkit.org/changeset/142756>
Comment 6 WebKit Review Bot 2013-02-13 09:26:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2013-02-13 12:38:49 PST
Re-opened since this is blocked by bug 109734