Bug 109553 - Web Inspector: Introduce version controller to migrate settings versions.
Summary: Web Inspector: Introduce version controller to migrate settings versions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on: 109589
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-12 00:44 PST by Vsevolod Vlasov
Modified: 2013-02-12 23:25 PST (History)
9 users (show)

See Also:


Attachments
Patch (10.38 KB, patch)
2013-02-12 00:45 PST, Vsevolod Vlasov
yurys: review+
yurys: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-02-12 00:44:07 PST
This patch introduces version controller that could be used to migrate inspector settings.
Comment 1 Vsevolod Vlasov 2013-02-12 00:45:29 PST
Created attachment 187799 [details]
Patch
Comment 2 Yury Semikhatsky 2013-02-12 01:46:31 PST
Comment on attachment 187799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187799&action=review

> Source/WebCore/inspector/front-end/Settings.js:352
> +WebInspector.VersionController = function()

Maybe WebInspector.Settings.VersionController ?

> LayoutTests/inspector/version-controller.html:6
> +{setTimeout(InspectorTest.completeTest.bind(InspectorTest), 1000);

Wrong alignment. Why do we need this timeout at all?
Comment 3 Vsevolod Vlasov 2013-02-12 06:30:52 PST
Committed r142614: <http://trac.webkit.org/changeset/142614>
Comment 4 WebKit Review Bot 2013-02-12 08:33:44 PST
Re-opened since this is blocked by bug 109589
Comment 5 Vsevolod Vlasov 2013-02-12 23:25:44 PST
Committed r142725: <http://trac.webkit.org/changeset/142725>