Currently WebInspector.SplitView code performs quite a few element.style manipulations. Most of these can replaced with simple CSS rules.
Created attachment 187561 [details] Patch
Comment on attachment 187561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187561&action=review Not really familiar with the code, but there's one style nit there. > Source/WebCore/inspector/front-end/SplitView.js:181 > + this._firstElement.style.cssText = ''; Web Inspector uses double quotes (") for enclosing string literals.
Comment on attachment 187561 [details] Patch I would revert the change in SplitView._removeAllLayoutProperties (what if split view elements have styles set externally?), other than that looks good.
Comment on attachment 187561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187561&action=review >> Source/WebCore/inspector/front-end/SplitView.js:181 >> + this._firstElement.style.cssText = ''; > > Web Inspector uses double quotes (") for enclosing string literals. Vsevik convinced me to roll back the change to this function, so the problem is no longer there.
Created attachment 187842 [details] Patch
Comment on attachment 187842 [details] Patch Rejecting attachment 187842 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 187842, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16519216
Created attachment 188051 [details] Patch
Comment on attachment 188051 [details] Patch Clearing flags on attachment: 188051 Committed r142738: <http://trac.webkit.org/changeset/142738>
All reviewed patches have been landed. Closing bug.
This patch broke SplitView in Canvas profiler. I requested a rollout, but sheriffbot failed. @Vladislav: Would you manually roll out this patch please, or plz fix the problem. A SplitView in CanvasProfileView.js no longer works.
Created attachment 188351 [details] Patch
Comment on attachment 188351 [details] Patch There is a bug-per patch policy that you should follow.
Regression addressed at https://bugs.webkit.org/show_bug.cgi?id=109835