Bug 109408 – Remove AttributeBase now that NEW_XML is gone

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Remove AttributeBase now that NEW_XML is gone

[Eric Seidel (no email)]

Created attachment 187523 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187523 [details]
Patch

Clearing flags on attachment: 187523

Committed r142480: <http://trac.webkit.org/changeset/142480>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 187523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187523&action=review

> Source/WebCore/xml/parser/MarkupTokenBase.h:67
> +    class Attribute {
> +    public:
> +        class Range {
> +        public:
> +            int m_start;
> +            int m_end;
> +        };
> +
> +        Range m_nameRange;
> +        Range m_valueRange;
> +        WTF::Vector<UChar, 32> m_name;
> +        WTF::Vector<UChar, 32> m_value;
> +    };

The WTF:: prefixes here are not needed.

Also, I notice a WebKit coding style anti-pattern here. In WebKit we use private data members, not public ones. When we want something with private data, we use struct, not class, and we name the data members without "m_" prefixes. So in WebKit coding style this would be:

struct Attribute {
    struct Range {
        int start;
        int end;
    };
    Range nameRange;
    Range valueRange;
    Vector<UChar, 32> name;
    Vector<UChar, 32> value;
};

[Eric Seidel (no email)]

Agreed.  Happy to fix the style in a follow-up patch.

[Eric Seidel (no email)]

I looked at this this morning.  gonna wait to fix this until we've killed MarkupTokenBase so that we can use String and AtomicString in this file. (which it currently seems to be avoiding).

[Eric Seidel (no email)]

(In reply to comment #4)
> (From update of attachment 187523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187523&action=review
> The WTF:: prefixes here are not needed.
> 
> Also, I notice a WebKit coding style anti-pattern here. In WebKit we use private data members, not public ones. When we want something with private data, we use struct, not class, and we name the data members without "m_" prefixes. So in WebKit coding style this would be:

Fixed in bug 109638