Bug 109638 - Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
Summary: Fix HTMLToken::Attribute member naming and update callsites to use Vector-bas...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 109617
Blocks: 109784
  Show dependency tree / graph
 
Reported: 2013-02-12 17:27 PST by Eric Seidel (no email)
Modified: 2013-02-13 22:17 PST (History)
7 users (show)

See Also:

Attachments
Patch (27.23 KB, patch)
2013-02-12 17:29 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-02-12 17:27:16 PST 
Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
Comment 1 Eric Seidel (no email) 2013-02-12 17:29:16 PST 
Created attachment 187974 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-12 20:26:09 PST 
Comment on attachment 187974 [details]
Patch

Clearing flags on attachment: 187974

Committed r142712: <http://trac.webkit.org/changeset/142712>
Comment 3 WebKit Review Bot 2013-02-12 20:26:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Eric Seidel (no email) 2013-02-13 21:59:54 PST 
I've since learned/re-learned that this is a change in behavior.

Previously String(UChar*, length) will treat length=0 as the empty string.

String(Vector) treats vector.size() == 0 as the null string.

This patch may need to be amended.