Bug 109390 – Remove support for RVCT version less than 4

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.

[Laszlo Gombos]

Related webkit-dev discussion - https://lists.webkit.org/pipermail/webkit-dev/2011-December/018884.html

Related bug on removing full support for RVCT (which I believe is not desired at this point of time) - bug 74251 .

[Laszlo Gombos]

Created attachment 187498 [details]
1st try

[WebKit Review Bot]

Attachment 187498 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.gypi', u'Source/WTF/WTF.vcproj/WTF.vcproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/Compiler.h', u'Source/WTF/wtf/Float32Array.h', u'Source/WTF/wtf/Float64Array.h', u'Source/WTF/wtf/Int16Array.h', u'Source/WTF/wtf/Int32Array.h', u'Source/WTF/wtf/Int8Array.h', u'Source/WTF/wtf/MathExtras.h', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/StringExtras.cpp', u'Source/WTF/wtf/StringExtras.h', u'Source/WTF/wtf/Uint16Array.h', u'Source/WTF/wtf/Uint32Array.h', u'Source/WTF/wtf/Uint8Array.h', u'Source/WTF/wtf/Uint8ClampedArray.h']" exit_code: 1
Source/WTF/wtf/Uint32Array.h:46:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WTF/wtf/Uint32Array.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Laszlo Gombos]

Created attachment 187499 [details]
fix style

[Zoltan Herczeg]

Comment on attachment 187499 [details]
fix style

LGTM. r=me

[Kwang Yul Seo]

(In reply to comment #0)
> The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.

BrewMP used to use RVCT < 4.0, but it has been already removed from the upstream. So this patch is okay to me.

[Laszlo Gombos]

(In reply to comment #6)
> (In reply to comment #0)
> > The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.
> 
> BrewMP used to use RVCT < 4.0, but it has been already removed from the upstream. So this patch is okay to me.

Thanks. I plan to land this patch in a week, so if you have any concerns please let me know. 

Also note that I have no means to verify the impact of this patch on ports building with RVCT >= v4.0 (e.g. BlackBerry) to make sure that it does not introduce any regressions, so if anyone is interested to help me that that that would be appreciated.

[WebKit Review Bot]

Comment on attachment 187499 [details]
fix style

Clearing flags on attachment: 187499

Committed r143061: <http://trac.webkit.org/changeset/143061>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.