Bug 109390 - Remove support for RVCT version less than 4
Summary: Remove support for RVCT version less than 4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-10 15:56 PST by Laszlo Gombos
Modified: 2013-02-15 15:14 PST (History)
13 users (show)

See Also:


Attachments
1st try (19.84 KB, patch)
2013-02-10 17:32 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff
fix style (19.83 KB, patch)
2013-02-10 17:43 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-02-10 15:56:26 PST
The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.
Comment 1 Laszlo Gombos 2013-02-10 15:58:29 PST
Related webkit-dev discussion - https://lists.webkit.org/pipermail/webkit-dev/2011-December/018884.html

Related bug on removing full support for RVCT (which I believe is not desired at this point of time) - bug 74251 .
Comment 2 Laszlo Gombos 2013-02-10 17:32:00 PST
Created attachment 187498 [details]
1st try
Comment 3 WebKit Review Bot 2013-02-10 17:35:13 PST
Attachment 187498 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.gypi', u'Source/WTF/WTF.vcproj/WTF.vcproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/Compiler.h', u'Source/WTF/wtf/Float32Array.h', u'Source/WTF/wtf/Float64Array.h', u'Source/WTF/wtf/Int16Array.h', u'Source/WTF/wtf/Int32Array.h', u'Source/WTF/wtf/Int8Array.h', u'Source/WTF/wtf/MathExtras.h', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/StringExtras.cpp', u'Source/WTF/wtf/StringExtras.h', u'Source/WTF/wtf/Uint16Array.h', u'Source/WTF/wtf/Uint32Array.h', u'Source/WTF/wtf/Uint8Array.h', u'Source/WTF/wtf/Uint8ClampedArray.h']" exit_code: 1
Source/WTF/wtf/Uint32Array.h:46:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WTF/wtf/Uint32Array.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Laszlo Gombos 2013-02-10 17:43:45 PST
Created attachment 187499 [details]
fix style
Comment 5 Zoltan Herczeg 2013-02-10 23:27:36 PST
Comment on attachment 187499 [details]
fix style

LGTM. r=me
Comment 6 Kwang Yul Seo 2013-02-11 21:23:50 PST
(In reply to comment #0)
> The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.

BrewMP used to use RVCT < 4.0, but it has been already removed from the upstream. So this patch is okay to me.
Comment 7 Laszlo Gombos 2013-02-12 07:51:31 PST
(In reply to comment #6)
> (In reply to comment #0)
> > The most dominant user of RVCT < 4.0 has been the Symbian port which has been removed from WebKit trunk. RVCT version >=4.0 is still used by the BlackBerry (and potentially some others port on Linux) ports.
> 
> BrewMP used to use RVCT < 4.0, but it has been already removed from the upstream. So this patch is okay to me.

Thanks. I plan to land this patch in a week, so if you have any concerns please let me know. 

Also note that I have no means to verify the impact of this patch on ports building with RVCT >= v4.0 (e.g. BlackBerry) to make sure that it does not introduce any regressions, so if anyone is interested to help me that that that would be appreciated.
Comment 8 WebKit Review Bot 2013-02-15 15:14:09 PST
Comment on attachment 187499 [details]
fix style

Clearing flags on attachment: 187499

Committed r143061: <http://trac.webkit.org/changeset/143061>
Comment 9 WebKit Review Bot 2013-02-15 15:14:15 PST
All reviewed patches have been landed.  Closing bug.