Bug 74251 – Remove support for the RVCT compiler.

• Status: NEW
• Component: JavaScriptCore

[Andreas Kling]

SSIA

[Andreas Kling]

Actually, I should qualify. The RealView compiler (RVCT) was only used by the now-defunct Symbian port of WebKit.

[Andreas Kling]

Created attachment 118702 [details]
Patch

[Benjamin Poulain]

Comment on attachment 118702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118702&action=review

I am find with the Symbian defines, but the Linux RVCT ones probably need to stay.
Let's wait until there are response on WebKit-dev.

e.g.:

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:-177
> -#if CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -
> -__asm void ExecutableAllocator::cacheFlush(void* code, size_t size)
> -{
> -    ARM
> -    push {r7}
> -    add r1, r1, r0
> -    mov r7, #0xf0000
> -    add r7, r7, #0x2
> -    mov r2, #0x0
> -    svc #0x0
> -    pop {r7}
> -    bx lr
> -}
> -
> -#endif
> -

I doubt this is related to Symbian's RVCT.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:-186
> -#elif CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -    static __asm void cacheFlush(void* code, size_t size);

Ditto

[Gustavo Noronha (kov)]

Comment on attachment 118702 [details]
Patch

Attachment 118702 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10826798

[Laszlo Gombos]

Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.

Is this configuration still a goal (with Qt5) ?

[Simon Hausmann]

(In reply to comment #5)
> Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.
> 
> Is this configuration still a goal (with Qt5) ?

Nope, RVCT is not on our radar anymore.

[Gabor Loki]

(In reply to comment #5)
> Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.
> 
> Is this configuration still a goal (with Qt5) ?

I am going to ask around a bit if there is any interest about RVDS support.