Bug 74251 - Remove support for the RVCT compiler.
Summary: Remove support for the RVCT compiler.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-10 18:44 PST by Andreas Kling
Modified: 2013-01-30 05:26 PST (History)
6 users (show)

See Also:


Attachments
Patch (22.81 KB, patch)
2011-12-10 18:49 PST, Andreas Kling
gns: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-10 18:44:21 PST
SSIA
Comment 1 Andreas Kling 2011-12-10 18:44:58 PST
Actually, I should qualify. The RealView compiler (RVCT) was only used by the now-defunct Symbian port of WebKit.
Comment 2 Andreas Kling 2011-12-10 18:49:48 PST
Created attachment 118702 [details]
Patch
Comment 3 Benjamin Poulain 2011-12-10 19:12:17 PST
Comment on attachment 118702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118702&action=review

I am find with the Symbian defines, but the Linux RVCT ones probably need to stay.
Let's wait until there are response on WebKit-dev.

e.g.:

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:-177
> -#if CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -
> -__asm void ExecutableAllocator::cacheFlush(void* code, size_t size)
> -{
> -    ARM
> -    push {r7}
> -    add r1, r1, r0
> -    mov r7, #0xf0000
> -    add r7, r7, #0x2
> -    mov r2, #0x0
> -    svc #0x0
> -    pop {r7}
> -    bx lr
> -}
> -
> -#endif
> -

I doubt this is related to Symbian's RVCT.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:-186
> -#elif CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -    static __asm void cacheFlush(void* code, size_t size);

Ditto
Comment 4 Gustavo Noronha (kov) 2011-12-10 21:53:54 PST
Comment on attachment 118702 [details]
Patch

Attachment 118702 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10826798
Comment 5 Laszlo Gombos 2013-01-27 20:52:24 PST
Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.

Is this configuration still a goal (with Qt5) ?
Comment 6 Simon Hausmann 2013-01-30 02:18:01 PST
(In reply to comment #5)
> Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.
> 
> Is this configuration still a goal (with Qt5) ?

Nope, RVCT is not on our radar anymore.
Comment 7 Gabor Loki 2013-01-30 05:26:28 PST
(In reply to comment #5)
> Adding a few people from the Qt port. I believe that the "OS(LINUX) && COMPILER(RVCT)" target was put to support building QtWebKit with RVCT on Linux.
> 
> Is this configuration still a goal (with Qt5) ?

I am going to ask around a bit if there is any interest about RVDS support.