Bug 109291 – REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ádám Kallai]

These compositing test started to fail after r142112.

 * compositing/iframes/iframe-composited-scrolling.html
Diff is here:

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/iframes/iframe-composited-scrolling-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/iframes/iframe-composited-scrolling-actual.txt
@@ -1,2 +1,2 @@
  
-PASS
+FAIL


 * compositing/layer-creation/fixed-position-in-view-dynamic.html
Diff is here:

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-in-view-dynamic-actual.txt
@@ -1,2 +1,2 @@
-PASS
+FAIL: Has viewport constrained objects without supporting fixed layers
 
 * compositing/layer-creation/fixed-position-out-of-view-dynamic.html
Diff is here:

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-out-of-view-dynamic-actual.txt
@@ -1,2 +1,2 @@
-PASS
+FAIL: Has viewport constrained objects without supporting fixed layers
 
 * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html
Diff is here:

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-out-of-view-scroll-reason-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/fixed-position-out-of-view-scroll-reason-actual.txt
@@ -1,2 +1,3 @@
 Main thread scrolling reasons should be blank:
+Has viewport constrained objects without supporting fixed layers
 
 * compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html
Diff is here:

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-actual.txt
@@ -15,4 +15,4 @@
     )
   )
 )
-
+Has viewport constrained objects without supporting fixed layers

Could you check it please?

[Ádám Kallai]

Two scrollingcoordinator tests failing too.

 * scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-actual.txt
@@ -10,3 +10,5 @@
     layer at (0,0) size 285x1016
       RenderBlock {HTML} at (0,0) size 285x1016
         RenderBody {BODY} at (8,8) size 1000x1000
+layer at (62,62) size 300x200
+  RenderBlock (positioned) {DIV} at (62,62) size 300x200 [bgcolor=#00FF00]

 * scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-actual.txt
@@ -10,3 +10,5 @@
     layer at (0,0) size 285x1016
       RenderBlock {HTML} at (0,0) size 285x1016
         RenderBody {BODY} at (8,8) size 1000x1000
+layer at (62,62) size 600x400
+  RenderBlock (positioned) {DIV} at (62,62) size 600x400 [bgcolor=#00FF00]

It seems this results aren't correct. Could you check these ones too?

[Ádám Kallai]

Skipped: <http://trac.webkit.org/changeset/142274>

[Allan Sandfeld Jensen]

(In reply to comment #1)
> Two scrollingcoordinator tests failing too.
> 
These two just needs to be rebased. They are much closer to the official baseline now than before.

[Allan Sandfeld Jensen]

Created attachment 187825 [details]
Patch

[Allan Sandfeld Jensen]

Review?

[Allan Sandfeld Jensen]

Committed r144901: <http://trac.webkit.org/changeset/144901>

[Gábor Ábrahám]

compositing/iframes/iframe-composited-scrolling.html 
This test now failing on Qt-wk2 could you check it please?