Bug 109207 - Disable All WebGL Tests on WebKit for Windows
Summary: Disable All WebGL Tests on WebKit for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks: 94643
  Show dependency tree / graph
 
Reported: 2013-02-07 09:40 PST by Gregg Tavares
Modified: 2013-02-11 21:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2013-02-07 09:40 PST, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (2.47 KB, patch)
2013-02-08 19:08 PST, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2013-02-07 09:40:03 PST 
Disable All WebGL Tests on WebKit for Windows
Comment 1 Gregg Tavares 2013-02-07 09:40:26 PST 
Created attachment 187127 [details]
Patch
Comment 2 Gregg Tavares 2013-02-07 10:16:40 PST 
Hey Dean, Can you review this?
Comment 3 Build Bot 2013-02-07 16:03:28 PST 
Comment on attachment 187127 [details]
Patch

Attachment 187127 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16432387
Comment 4 Roger Fong 2013-02-07 18:00:42 PST 
Ignore the win bots failing, that's just me futzing with EWS bots.
Comment 5 Gregg Tavares 2013-02-07 19:24:48 PST 
I still need someone to mark this as r+ and I'm not sure how to re-submit it.
Comment 6 Roger Fong 2013-02-08 00:29:10 PST 
Honestly, for something like skipping tests you can just land it without review. Just stick 'unreviewed' in the change log and we're good to go.
Thanks!
Comment 7 WebKit Review Bot 2013-02-08 17:07:34 PST 
Comment on attachment 187127 [details]
Patch

Rejecting attachment 187127 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 187127, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16426958
Comment 8 Gregg Tavares 2013-02-08 19:08:01 PST 
Created attachment 187398 [details]
Patch
Comment 9 Gregg Tavares 2013-02-08 19:10:07 PST 
Committed r142342: <http://trac.webkit.org/changeset/142342>
Comment 10 Kenneth Russell 2013-02-11 21:40:32 PST 
Comment on attachment 187398 [details]
Patch

Since this was landed already, clearing the review bit.