Bug 109136 – REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

CalendarPicker.fixWindowSize is broken.

[Keishi Hattori]

Created attachment 186994 [details]
Patch

[Kent Tamura]

Comment on attachment 186994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186994&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests. Covered by existing calendar picker appearance tests.

Really? Do we have a calendar picker test with <input type=date required>?

[Keishi Hattori]

Created attachment 187025 [details]
Patch

[Kent Tamura]

Comment on attachment 187025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187025&action=review

> LayoutTests/platform/chromium/TestExpectations:4252
> +webkit.org/b/107508 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html [ ImageOnlyFailure Pass ]
> +webkit.org/b/107508 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass ]

Wrong bug number.  They should be 109136.

[Keishi Hattori]

Created attachment 187028 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187028 [details]
Patch

Clearing flags on attachment: 187028

Committed r142111: <http://trac.webkit.org/changeset/142111>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

https://bugs.webkit.org/show_bug.cgi?id=108055#c10

Comment #10 From Gavin Peters 2013-02-07 08:39:06 PST (-) [reply]
Reverted r142111 for reason:

win7 bot didn't display arabic

Committed r142130: <http://trac.webkit.org/changeset/142130>

Comment #11 From Gavin Peters 2013-02-07 09:12:40 PST (-) [reply]
The win7 calendar lacked Arabic: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html , so I wan't comfortable rebaselining this myself.

[Kent Tamura]

Comment on attachment 187028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187028&action=review

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=108055

wrong bug number

> LayoutTests/platform/chromium/TestExpectations:4252
> +webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html [ ImageOnlyFailure Pass ]
> +webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass ]

Need to add "Missing"

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html:14
> +<input type=date id=date value="1800-12-31" required lang="ar_AE">

I think ar_AE is wrong.  It should be ar-AE.

[Kent Tamura]

Committed r142198: <http://trac.webkit.org/changeset/142198>

[Kent Tamura]

(In reply to comment #10)
> Committed r142198: <http://trac.webkit.org/changeset/142198>

I verified this worked on Windows 7 buildbot.

[Keishi Hattori]

(In reply to comment #11)
> (In reply to comment #10)
> > Committed r142198: <http://trac.webkit.org/changeset/142198>
> 
> I verified this worked on Windows 7 buildbot.

I'm sorry. Thanks!

[Kent Tamura]

*** Bug 110010 has been marked as a duplicate of this bug. ***