Bug 108055 - [REGRESSION] Calendar Picker focus ring is gone
Summary: [REGRESSION] Calendar Picker focus ring is gone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-27 23:51 PST by Keishi Hattori
Modified: 2013-02-07 15:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2013-01-28 00:59 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2013-01-28 01:20 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (58.63 KB, patch)
2013-02-07 01:20 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2013-01-27 23:51:23 PST 
This is because -webkit-focus-ring-color is only allowed for outline property in strict mode.
Comment 1 Keishi Hattori 2013-01-28 00:59:34 PST 
Created attachment 184947 [details]
Patch
Comment 2 Kent Tamura 2013-01-28 01:02:20 PST 
Comment on attachment 184947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184947&action=review

> Source/WebCore/ChangeLog:12
> +        Can't reproduce in layout test.

You had better add a reason.
Comment 3 Keishi Hattori 2013-01-28 01:20:07 PST 
Created attachment 184950 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-28 01:40:46 PST 
Comment on attachment 184950 [details]
Patch

Clearing flags on attachment: 184950

Committed r140955: <http://trac.webkit.org/changeset/140955>
Comment 5 WebKit Review Bot 2013-01-28 01:40:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Keishi Hattori 2013-02-07 01:20:19 PST 
Reopening to attach new patch.
Comment 7 Keishi Hattori 2013-02-07 01:20:22 PST 
Created attachment 187020 [details]
Patch
Comment 8 Kent Tamura 2013-02-07 01:48:30 PST 
(In reply to comment #6)
> Reopening to attach new patch.

Did you post a patch to a wrong bug?
Comment 9 Keishi Hattori 2013-02-07 01:50:28 PST 
Sorry my mistake.
Comment 10 Gavin Peters 2013-02-07 08:39:06 PST 
Reverted r142111 for reason:

win7 bot didn't display arabic

Committed r142130: <http://trac.webkit.org/changeset/142130>
Comment 11 Gavin Peters 2013-02-07 09:12:40 PST 
The win7 calendar lacked Arabic: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html , so I wan't comfortable rebaselining this myself.
Comment 12 Kent Tamura 2013-02-07 15:52:16 PST 
gavin, this is a wrong bug. Let's move to Bug 109136