Bug 109075 – Adds failing WebGL Conformance Tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Gregg Tavares]

Adds failing WebGL Conformance Tests.

[Gregg Tavares]

Created attachment 186882 [details]
Patch

[Kenneth Russell]

Comment on attachment 186882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186882&action=review

Looks good. A couple of tiny issues in the TestExpectations.

> LayoutTests/platform/chromium/TestExpectations:1476
> +crbug.com/174666 webgl/conformance/context/context-creation-and-destruction.html [ Skip ]

Wrong bug ID on this line.

> LayoutTests/platform/mac/TestExpectations:971
> +# https://bugs.webkit.org/show_bug.cgi?id=?????

Need a bug ID here.

[Gregg Tavares]

Created attachment 186889 [details]
Patch

[Kenneth Russell]

Comment on attachment 186889 [details]
Patch

Looks good.

[Build Bot]

Comment on attachment 186889 [details]
Patch

Attachment 186889 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16400250

[Gregg Tavares]

Created attachment 186942 [details]
Patch

[Gregg Tavares]

Committed r142058: <http://trac.webkit.org/changeset/142058>

[Matt Falkenhagen]

These two tests are timing out:
webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html
webgl/conformance/uniforms/uniform-default-values.html

Should we just mark webgl/conformance as Slow?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=webgl%2Fconformance%2Fogles%2FGL%2Fcontrol_flow%2Fcontrol_flow_001_to_008.html

[Matt Falkenhagen]

I noticed many other tests in the directory are timing out. I'll mark it Slow and see if it helps.

However there are also two crashes. I'm not sure if these are expected:

webgl/conformance/more/conformance/quickCheckAPI-A.html
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/5823/steps/webkit_tests/logs/stdio
19:38:51.545 1269 worker/2 webgl/conformance/more/conformance/quickCheckAPI-A.html crashed, (stderr lines):
19:38:51.545 1269   #EOF
19:38:51.545 1269   Received signal 11 SEGV_MAPERR 0000ff00ff04

webgl/conformance/uniforms/gl-uniform-arrays.html
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/5505/steps/webkit_tests/logs/stdio
crash log for DumpRenderTree (pid 7324):
STDOUT: <empty>
STDERR: [7324:7324:7872596071827:ERROR:gles2_cmd_decoder.cc(5486)] .WebGLRenderingContext: GL ERROR :GL_INVALID_OPERATION : glUniform2fv: wrong uniform function for type
STDERR: [7324:7324:7872596193041:ERROR:gles2_cmd_decoder.cc(5486)] .WebGLRenderingContext: GL ERROR :GL_INVALID_OPERATION : glUniform1fv: wrong uniform function for type
STDERR: [7324:7324:7872596309095:ERROR:gles2_cmd_decoder.cc(5486)] .WebGLRenderingContext: GL ERROR :GL_INVALID_OPERATION : glUniform1fv: wrong uniform function for type
STDERR: [7324:7324:7872596428275:ERROR:gles2_cmd_decoder.cc(5486)] .WebGLRenderingContext: GL ERROR :GL_INVALID_OPERATION : glUniform1fv: wrong uniform function for type
STDERR: DumpRenderTree: ../../third_party/mesa/MesaLib/src/mesa/program/ir_to_mesa.cpp:2218: prog_src_register mesa_src_reg_from_ir_src_reg(ir_to_mesa_src_reg): Assertion `reg.index < (1 << 10) - 1' failed.
STDERR: Received signal 6
STDERR:  [0x7ff1af8b967c] base::debug::StackTrace::StackTrace()
STDERR:  [0x7ff1af8b8f26] base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR:  [0x7ff1a4dce8f0] <unknown>
STDERR:  [0x7ff1a4a6ea75] gsignal
STDERR:  [0x7ff1a4a725c0] abort
STDERR:  [0x7ff1a4a67941] __assert_fail
STDERR:  [0x7ff19cab531b] mesa_src_reg_from_ir_src_reg()
STDERR:  [0x7ff19cab6818] get_mesa_program()
STDERR:  [0x7ff19cab6f68] _mesa_ir_link_shader
STDERR:  [0x7ff19cab756c] _mesa_glsl_link_shader
STDERR:  [0x7ff19ca71f70] link_program
STDERR:  [0x7ff19ca72d23] _mesa_LinkProgramARB
STDERR:  [0x7ff19cbc3ce9] glLinkProgram
STDERR:  [0x7ff1b1f4aee9] gfx::GLApiBase::glLinkProgramFn()
STDERR:  [0x7ff1a47236a6] gpu::gles2::ProgramManager::ProgramInfo::Link()
STDERR:  [0x7ff1a46e3b17] gpu::gles2::GLES2DecoderImpl::DoLinkProgram()
STDERR:  [0x7ff1a46faf46] gpu::gles2::GLES2DecoderImpl::HandleLinkProgram()
STDERR:  [0x7ff1a46dca22] gpu::gles2::GLES2DecoderImpl::DoCommand()
STDERR:  [0x7ff1a46b0942] gpu::CommandParser::ProcessCommand()
STDERR:  [0x7ff1a470fb4b] gpu::GpuScheduler::PutChanged()
STDERR:  [0x7ff1b1fcb432] webkit::gpu::GLInProcessContext::PumpCommands()
STDERR:  [0x7ff1b1fd73e5] base::internal::RunnableAdapter<>::Run()
STDERR:  [0x7ff1b1fd6cb6] base::internal::InvokeHelper<>::MakeItSo()
STDERR:  [0x7ff1b1fd5f76] base::internal::Invoker<>::Run()
STDERR:  [0x7ff1a46b1e99] base::Callback<>::Run()
STDERR:  [0x7ff1a46b12e3] gpu::CommandBufferService::FlushSync()
STDERR:  [0x7ff1a469e944] gpu::CommandBufferHelper::FlushSync()
STDERR:  [0x7ff1a469eb12] gpu::CommandBufferHelper::Finish()
STDERR:  [0x7ff1a49a8130] gpu::gles2::GLES2Implementation::WaitForCmd()
STDERR:  [0x7ff1a49a8cc4] gpu::gles2::GLES2Implementation::GetBucketContents()
STDERR:  [0x7ff1a49b7ee4] gpu::gles2::GLES2Implementation::GetProgramInfoCHROMIUMHelper()
STDERR:  [0x7ff1a49ea36d] gpu::gles2::CachedProgramInfoManager::ProgramInfo::Update()
STDERR:  [0x7ff1a49eaaa2] gpu::gles2::CachedProgramInfoManager::GetProgramInfo()
STDERR:  [0x7ff1a49eac7a] gpu::gles2::CachedProgramInfoManager::GetProgramiv()
STDERR:  [0x7ff1a49ace75] gpu::gles2::GLES2Implementation::GetProgramivHelper()
STDERR:  [0x7ff1a49c2e46] gpu::gles2::GLES2Implementation::GetProgramiv()
STDERR:  [0x7ff1b1fcf24b] webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl::getProgramiv()
STDERR:  [0x7ff1ab6f16f2] WebCore::GraphicsContext3D::getProgramiv()
STDERR:  [0x7ff1acf2c2f7] WebCore::WebGLProgram::cacheInfoIfNeeded()
STDERR:  [0x7ff1acf2bec6] WebCore::WebGLProgram::getLinkStatus()
STDERR:  [0x7ff1acf394d7] WebCore::WebGLRenderingContext::getProgramParameter()
STDERR:  [0x7ff1ac8311f6] WebCore::V8WebGLRenderingContext::getProgramParameterCallback()
STDERR:  [0x234c55a2f297] <unknown>

[Matt Falkenhagen]

Marked as slow. For more details, the additional timed out tests were:

webgl/conformance/more/conformance/quickCheckAPI-A.html
webgl/conformance/more/conformance/quickCheckAPI-B1.html
webgl/conformance/more/conformance/quickCheckAPI-B2.html
webgl/conformance/more/conformance/quickCheckAPI-B3.html
webgl/conformance/more/conformance/quickCheckAPI-B4.html
webgl/conformance/more/conformance/quickCheckAPI-C.html
webgl/conformance/more/conformance/quickCheckAPI-D_G.html
webgl/conformance/more/conformance/quickCheckAPI-G_I.html
webgl/conformance/more/conformance/quickCheckAPI-L_S.html
webgl/conformance/more/conformance/quickCheckAPI-S_V.html
webgl/conformance/more/functions/bufferDataBadArgs.html
webgl/conformance/more/functions/copyTexImage2D.html
webgl/conformance/more/functions/copyTexImage2DBadArgs.html
webgl/conformance/more/functions/copyTexSubImage2D.html
webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html
webgl/conformance/more/functions/deleteBufferBadArgs.html
webgl/conformance/more/functions/drawArrays.html
webgl/conformance/more/functions/drawArraysOutOfBounds.html
webgl/conformance/more/functions/drawElements.html
webgl/conformance/more/functions/drawElementsBadArgs.html
webgl/conformance/more/functions/readPixelsBadArgs.html
webgl/conformance/more/functions/texImage2DBadArgs.html
webgl/conformance/more/functions/texImage2DHTML.html
webgl/conformance/more/functions/texSubImage2DBadArgs.html
webgl/conformance/more/functions/texSubImage2DHTML.html
webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html
webgl/conformance/state/gl-object-get-calls.html
webgl/conformance/textures/texture-size-limit.html
webgl/conformance/textures/texture-size.html
webgl/conformance/uniforms/gl-uniform-arrays.html
webgl/conformance/uniforms/uniform-samplers-test.html

[Matt Falkenhagen]

I think I have to revert. Some of the tests are also crashing on AppleMac, e.g.:

http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29/builds/7198/steps/layout-test/logs/stdio

and the Slow modifier on Chromium did not help completely (TestExpectations may not work this way anyway).

[Gregg Tavares]

(In reply to comment #11)
> I think I have to revert. Some of the tests are also crashing on AppleMac, e.g.:
> 
> http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29/builds/7198/steps/layout-test/logs/stdio
> 
> and the Slow modifier on Chromium did not help completely (TestExpectations may not work this way anyway).

can you mark them as skip?

If not go ahead and revert.

It's frustrating that these all ran on EWS and locally in 3 different configurations :-(

[Matt Falkenhagen]

(In reply to comment #12)
> (In reply to comment #11)
> > I think I have to revert. Some of the tests are also crashing on AppleMac, e.g.:
> > 
> > http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29/builds/7198/steps/layout-test/logs/stdio
> > 
> > and the Slow modifier on Chromium did not help completely (TestExpectations may not work this way anyway).
> 
> can you mark them as skip?
> 
> If not go ahead and revert.
> 
> It's frustrating that these all ran on EWS and locally in 3 different configurations :-(

Ah sorry I saw this too late. I think it would have required adding to Skip on each platform's TestExpectations and reverting seemed to make more sense.

Yeah it seems like a major pain :-(
Let me know if I can help by providing more links to failures.

[Gregg Tavares]

I'll mark all these tests as skip for now

[Gregg Tavares]

Created attachment 187134 [details]
Patch

[Build Bot]

Comment on attachment 187134 [details]
Patch

Attachment 187134 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16435292

New failing tests:
webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html

[Build Bot]

Comment on attachment 187134 [details]
Patch

Attachment 187134 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16428337

New failing tests:
webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html

[Gregg Tavares]

Created attachment 187165 [details]
Patch

[Gregg Tavares]

Created attachment 187399 [details]
Patch

[Build Bot]

Comment on attachment 187399 [details]
Patch

Attachment 187399 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16476332

New failing tests:
compositing/checkerboard.html
accessibility/anchor-linked-anonymous-block-crash.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
http/tests/cache/cancel-multiple-post-xhrs.html
animations/3d/state-at-end-event-transform.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
http/tests/cache/history-only-cached-subresource-loads.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
accessibility/accessibility-object-detached.html
accessibility/anonymous-render-block-in-continuation-causes-crash.html
animations/animation-controller-drt-api.html
compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/absolute-position-changed-in-composited-layer.html
http/tests/cache/iframe-304-crash.html
animations/3d/transform-perspective.html
http/tests/cache/cancel-during-failure-crash.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
canvas/philip/tests/2d.clearRect.basic.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
animations/animation-css-rule-types.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html

[Gregg Tavares]

Created attachment 187602 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187602 [details]
Patch

Attachment 187602 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16439398

New failing tests:
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html
webgl/conformance/more/functions/deleteBufferBadArgs.html
webgl/conformance/more/conformance/quickCheckAPI-S_V.html
webgl/conformance/more/functions/texImage2DBadArgs.html
webgl/conformance/more/conformance/quickCheckAPI-A.html
webgl/conformance/more/conformance/quickCheckAPI-C.html
webgl/conformance/more/functions/copyTexImage2D.html
webgl/conformance/more/conformance/quickCheckAPI-L_S.html
webgl/conformance/more/functions/texSubImage2DBadArgs.html
webgl/conformance/more/conformance/quickCheckAPI-G_I.html
webgl/conformance/more/conformance/quickCheckAPI-B4.html
webgl/conformance/more/functions/drawArraysOutOfBounds.html
webgl/conformance/more/functions/copyTexSubImage2D.html
webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html
webgl/conformance/more/conformance/quickCheckAPI-B2.html
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
webgl/conformance/more/functions/drawArrays.html
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
webgl/conformance/more/conformance/quickCheckAPI-D_G.html
webgl/conformance/more/conformance/quickCheckAPI-B1.html
webgl/conformance/more/functions/drawElementsBadArgs.html
webgl/conformance/more/conformance/quickCheckAPI-B3.html
webgl/conformance/more/functions/copyTexImage2DBadArgs.html
webgl/conformance/more/functions/drawElements.html

[Gregg Tavares]

Created attachment 187931 [details]
Patch

[Gregg Tavares]

Committed r142847: <http://trac.webkit.org/changeset/142847>

[Eric Seidel (no email)]

Comment on attachment 187931 [details]
Patch

Cleared review? from attachment 187931 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Simon Fraser (smfr)]

Why did this patch disable ALL webgl tests on Mac?