Bug 109060 - Use GL typedefs in WebGLRenderingContext.idl
Summary: Use GL typedefs in WebGLRenderingContext.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 52340
Blocks: 108649
  Show dependency treegraph
 
Reported: 2013-02-06 08:58 PST by Andrey Adaikin
Modified: 2013-02-14 23:03 PST (History)
14 users (show)

See Also:


Attachments
Patch (72.09 KB, patch)
2013-02-07 05:29 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (72.18 KB, patch)
2013-02-14 04:16 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-02-06 08:58:08 PST
Once we support typedefs in WebKit IDL parser we should use GL typedefs in WebGLRenderingContext.idl according to specs.
Comment 1 Andrey Adaikin 2013-02-07 05:29:14 PST
Created attachment 187070 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-07 05:34:40 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16435138
Comment 3 EFL EWS Bot 2013-02-07 05:37:18 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16438135
Comment 4 Early Warning System Bot 2013-02-07 05:38:20 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16427122
Comment 5 Build Bot 2013-02-07 06:29:35 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16430158
Comment 6 kov's GTK+ EWS bot 2013-02-07 06:37:02 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16418164
Comment 7 WebKit Review Bot 2013-02-07 06:59:56 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16428194
Comment 8 Peter Beverloo (cr-android ews) 2013-02-07 07:25:06 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16428180
Comment 9 Build Bot 2013-02-07 07:32:22 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16415311
Comment 10 WebKit Review Bot 2013-02-07 10:20:36 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16408383
Comment 11 Andrey Adaikin 2013-02-07 10:37:57 PST
Sorry for the bots warnings. This patch depends on https://bugs.webkit.org/show_bug.cgi?id=52340
Comment 12 Build Bot 2013-02-07 11:31:18 PST
Comment on attachment 187070 [details]
Patch

Attachment 187070 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16438276
Comment 13 Zhenyao Mo 2013-02-07 16:19:16 PST
This is awesome!  Thanks for doing this patch.
Comment 14 Zhenyao Mo 2013-02-07 16:21:49 PST
LGTM
Comment 15 Kenneth Russell 2013-02-11 21:44:33 PST
Comment on attachment 187070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187070&action=review

This will be great -- really looking forward to seeing this go in. The patch looks good overall. However, the patch for bug 52340, which this depends on, still has issues to be resolved, and has to land before the early warning system bots can properly process this patch. I'm marking this r- because it can't be properly reviewed yet. Please resubmit this patch and request review when the fix for bug 52340 has landed.

> Source/WebCore/ChangeLog:16
>          Look into possibilities of typedef in webkit idl files

The ChangeLog will need to be regenerated after the fix for bug 52340 lands.
Comment 16 Andrey Adaikin 2013-02-14 04:16:16 PST
Created attachment 188313 [details]
Patch
Comment 17 Kenneth Russell 2013-02-14 10:51:37 PST
Comment on attachment 188313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review

This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:540
>      [StrictTypeChecking] int          getAttribLocation(in WebGLProgram program, in DOMString name);

Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy?
Comment 18 Andrey Adaikin 2013-02-14 22:53:19 PST
(In reply to comment #17)
> (From update of attachment 188313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review
> 
> This looks great. Thank you for pushing this through. It brings WebKit's IDL much closer to the real Web IDL for this spec. r=me
> 
> > Source/WebCore/html/canvas/WebGLRenderingContext.idl:540
> >      [StrictTypeChecking] int          getAttribLocation(in WebGLProgram program, in DOMString name);
> 
> Is there some issue with changing this to return GLint? Could you file a bug to track this discrepancy?

Filed https://bugs.webkit.org/show_bug.cgi?id=109892
Comment 19 WebKit Review Bot 2013-02-14 23:03:12 PST
Comment on attachment 188313 [details]
Patch

Clearing flags on attachment: 188313

Committed r142967: <http://trac.webkit.org/changeset/142967>
Comment 20 WebKit Review Bot 2013-02-14 23:03:18 PST
All reviewed patches have been landed.  Closing bug.