Web Inspector: [WebGL] show WebGL enum names instead of numbers

[Andrey Adaikin]

In canvas replay log we should show WebGL enum names instead of numbers.

Patch to follow.

[Andrey Adaikin]

Created attachment 186060 [details]
Patch

[Andrey Adaikin]

Created attachment 186063 [details]
Screenshot

[Pavel Feldman]

Comment on attachment 186060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186060&action=review

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:2761
> +    f("activeTexture", 0);

Do you need a test that nothing is missing?

[Andrey Adaikin]

Created attachment 186331 [details]
Added a test

[Andrey Adaikin]

(In reply to comment #3)
> (From update of attachment 186060 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186060&action=review
> 
> > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:2761
> > +    f("activeTexture", 0);
> 
> Do you need a test that nothing is missing?

I added a test to dump some of those calls with enum descriptions.

To test automatically that nothing is missing seems impossible - only manually by checking the specs with scrupulous attention.

[Pavel Feldman]

> To test automatically that nothing is missing seems impossible - only manually by checking the specs with scrupulous attention.

But we can't afford it. Can you walk the wrapped object methods, etc.?

[Andrey Adaikin]

(In reply to comment #6)
> > To test automatically that nothing is missing seems impossible - only manually by checking the specs with scrupulous attention.
> 
> But we can't afford it. Can you walk the wrapped object methods, etc.?

I hardly can guess what you mean... But here is an example of a call in the log:

gl.texImage2D(3553, 0, 6408, 512, 512, 0, 6408, 5121, null);

Now, without consulting the specs, how do you know that only arguments at indexes {0,2,6,7} are enums? i.e.:

gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, 512, 512, 0, gl.RGBA, gl.UNSIGNED_BYTE, null);

[Pavel Feldman]

(In reply to comment #7)
> (In reply to comment #6)
> > > To test automatically that nothing is missing seems impossible - only manually by checking the specs with scrupulous attention.
> > 
> > But we can't afford it. Can you walk the wrapped object methods, etc.?
> 
> I hardly can guess what you mean... But here is an example of a call in the log:
> 
> gl.texImage2D(3553, 0, 6408, 512, 512, 0, 6408, 5121, null);
> 
> Now, without consulting the specs, how do you know that only arguments at indexes {0,2,6,7} are enums? i.e.:
> 
> gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, 512, 512, 0, gl.RGBA, gl.UNSIGNED_BYTE, null);

I don't know. Maybe via generating something off the idl and/or header. Otherwise this is a write-once work that is going to be out of date and not tested.

[Build Bot]

Comment on attachment 186331 [details]
Added a test

Attachment 186331 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16373193

New failing tests:
inspector/profiler/webgl/webgl-profiler-enum-descriptions.html

[Build Bot]

Comment on attachment 186331 [details]
Added a test

Attachment 186331 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16378117

New failing tests:
inspector/profiler/webgl/webgl-profiler-enum-descriptions.html

[Pavel Feldman]

Comment on attachment 186331 [details]
Added a test

As per comment #8.