Bug 109050 - Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional.
Summary: Invalid code is generated for storing constants with baseindex addressing mod...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2013-02-06 07:12 PST by Zoltan Herczeg
Modified: 2013-02-14 05:58 PST (History)
6 users (show)

See Also:

Attachments
patch (2.14 KB, patch)
2013-02-06 07:17 PST, Zoltan Herczeg 		no flags Details | Formatted Diff | Diff
improved patch (2.54 KB, patch)
2013-02-07 06:45 PST, Zoltan Herczeg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2013-02-06 07:12:52 PST 
S1 scratch register, which should hold the constant value, is reused during the process. Fix attached.
Comment 1 Zoltan Herczeg 2013-02-06 07:17:12 PST 
Created attachment 186850 [details]
patch
Comment 2 Zoltan Herczeg 2013-02-06 07:18:27 PST 
If we ever need bigger offsets, we can do that with a sequence of add/sub instructions. It will not be effective, but at least it will work.
Comment 3 Zoltan Herczeg 2013-02-07 06:45:27 PST 
Created attachment 187090 [details]
improved patch

Patch without assert.
Comment 4 Zoltan Herczeg 2013-02-07 06:46:31 PST 
Oliver, could you review it?
Comment 5 WebKit Review Bot 2013-02-07 10:05:43 PST 
Comment on attachment 187090 [details]
improved patch

Clearing flags on attachment: 187090

Committed r142146: <http://trac.webkit.org/changeset/142146>
Comment 6 WebKit Review Bot 2013-02-07 10:05:47 PST 
All reviewed patches have been landed.  Closing bug.