Bug 108825 - [EFL][WK2] Use C API inside EwkView
Summary: [EFL][WK2] Use C API inside EwkView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks: 107657
  Show dependency tree / graph
 
Reported: 2013-02-04 07:52 PST by Kenneth Rohde Christiansen
Modified: 2013-02-04 15:59 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2013-02-04 07:59 PST, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2013-02-04 07:52:53 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2013-02-04 07:59:27 PST 
Created attachment 186374 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2013-02-04 08:27:06 PST 
Comment on attachment 186374 [details]
Patch

LGTM
Comment 3 Chris Dumez 2013-02-04 08:33:16 PST 
Comment on attachment 186374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895
> +    WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString(""));

WKURLCopyString()?
Comment 4 Chris Dumez 2013-02-04 08:55:33 PST 
Comment on attachment 186374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895
>> +    WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString(""));
> 
> WKURLCopyString()?

Never mind. You are already using it. I did not read properly sorry.
Comment 5 Chris Dumez 2013-02-04 09:00:17 PST 
Oh, I forgot: LGTM :)
Comment 6 WebKit Review Bot 2013-02-04 15:59:12 PST 
Comment on attachment 186374 [details]
Patch

Clearing flags on attachment: 186374

Committed r141827: <http://trac.webkit.org/changeset/141827>
Comment 7 WebKit Review Bot 2013-02-04 15:59:17 PST 
All reviewed patches have been landed.  Closing bug.