Bug 108549 – Add platform support for -webkit-background-blend-mode to CG context

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rik Cabanier]

Add platforrm support for -webkit-background-blend-mode to CoreGraphics

[Rik Cabanier]

Created attachment 185934 [details]
not for review. Just to see if patch builds

[WebKit Review Bot]

Attachment 185934 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/compositing/background-blend-mode-property-expected.txt', u'LayoutTests/css3/compositing/background-blend-mode-property-parsing-expected.txt', u'LayoutTests/css3/compositing/background-blend-mode-property-parsing.html', u'LayoutTests/css3/compositing/background-blend-mode-property.html', u'LayoutTests/css3/compositing/script-tests/background-blend-mode-property-parsing.js', u'LayoutTests/css3/compositing/script-tests/background-blend-mode-property.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSProperty.cpp', u'Source/WebCore/css/CSSPropertyNames.in', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/CSSToStyleMap.h', u'Source/WebCore/css/StyleBuilder.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/cairo/ImageCairo.cpp', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/qt/ImageQt.cpp', u'Source/WebCore/platform/graphics/skia/ImageSkia.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/style/FillLayer.cpp', u'Source/WebCore/rendering/style/FillLayer.h']" exit_code: 1
Source/WebCore/platform/graphics/cairo/ImageCairo.cpp:46:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/GeneratorGeneratedImage.h:58:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBoxModelObject.cpp:961:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/platform/graphics/GeneratedImage.h:58:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/Image.h:179:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/Image.h:180:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/qt/ImageQt.cpp:135:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/GraphicsContext.h:330:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cg/ImageCG.cpp:77:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 10 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 185934 [details]
not for review. Just to see if patch builds

Attachment 185934 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16298385

New failing tests:
css3/compositing/background-blend-mode-property-parsing.html
css3/compositing/background-blend-mode-property.html

[WebKit Review Bot]

Comment on attachment 185934 [details]
not for review. Just to see if patch builds

Attachment 185934 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16309446

New failing tests:
css3/compositing/background-blend-mode-property-parsing.html
css3/compositing/background-blend-mode-property.html

[Build Bot]

Comment on attachment 185934 [details]
not for review. Just to see if patch builds

Attachment 185934 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16296758

[Simon Fraser (smfr)]

You're not asking for a new feature in CoreGraphics, right?

[Rik Cabanier]

(In reply to comment #6)
> You're not asking for a new feature in CoreGraphics, right?

No, this is just to implement background blending using CoreGraphics.

[Rik Cabanier]

Created attachment 187392 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187392 [details]
Patch

Attachment 187392 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16465084

[Early Warning System Bot]

Comment on attachment 187392 [details]
Patch

Attachment 187392 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16434943

[Rik Cabanier]

Created attachment 187393 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187392 [details]
Patch

Attachment 187392 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16469010

[Rik Cabanier]

Created attachment 187397 [details]
Patch

[WebKit Review Bot]

Attachment 187397 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html', u'LayoutTests/css3/compositing/effect-background-blend-mode.html', u'LayoutTests/css3/compositing/resources/ducky.png', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/qt/ImageQt.cpp', u'Source/WebCore/platform/graphics/skia/ImageSkia.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp']" exit_code: 1
Source/WebCore/platform/graphics/qt/ImageQt.cpp:135:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rik Cabanier]

Created attachment 187400 [details]
Patch

[EFL EWS Bot]

Comment on attachment 187392 [details]
Patch

Attachment 187392 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16431940

[EFL EWS Bot]

Comment on attachment 187400 [details]
Patch

Attachment 187400 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16438964

[Rik Cabanier]

Created attachment 187402 [details]
Patch

[Build Bot]

Comment on attachment 187402 [details]
Patch

Attachment 187402 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16469216

New failing tests:
http/tests/cache/cached-main-resource.html

[WebKit Review Bot]

Comment on attachment 187402 [details]
Patch

Attachment 187402 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16465637

New failing tests:
css3/compositing/effect-background-blend-mode.html
css3/compositing/effect-background-blend-mode-stacking.html

[Dean Jackson]

Comment on attachment 187402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187402&action=review

r+ with comments, and some tests to skip.

> Source/WebCore/platform/graphics/GraphicsContext.h:409
> +        BlendMode blendModeOperation() const;

It's a shame we have to append Operation here. Oh well.

> LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html:29
> +<li style="-webkit-box-reflect:below 5px -webkit-gradient(linear, left top, left bottom, from(transparent), color-stop(0.5, transparent), to(white));"></li>

You should use the unprefixed linear-gradient, like you did above.

> LayoutTests/css3/compositing/effect-background-blend-mode.html:16
> +	background:  url("resources/ducky.png") no-repeat 0 0 /100% 100%, linear-gradient(to right, #00ffff 0%, rgba(0,0,255,0) 24%, #ff0000 50%, #ffff00 75%, #00ff00 100%);

Do we have the rights to this ducky image?

[WebKit Review Bot]

Comment on attachment 187402 [details]
Patch

Attachment 187402 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16448041

New failing tests:
css3/compositing/effect-background-blend-mode.html
css3/compositing/effect-background-blend-mode-stacking.html

[Rik Cabanier]

Created attachment 187472 [details]
Patch

[WebKit Review Bot]

Attachment 187472 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html', u'LayoutTests/css3/compositing/effect-background-blend-mode.html', u'LayoutTests/css3/compositing/resources/ducky.png', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/cairo/ImageCairo.cpp', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/qt/ImageQt.cpp', u'Source/WebCore/platform/graphics/skia/ImageSkia.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp']" exit_code: 1
LayoutTests/platform/chromium/TestExpectations:145:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:146:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rik Cabanier]

(In reply to comment #21)
> (From update of attachment 187402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187402&action=review
> 
> r+ with comments, and some tests to skip.
> 
> > Source/WebCore/platform/graphics/GraphicsContext.h:409
> > +        BlendMode blendModeOperation() const;
> 
> It's a shame we have to append Operation here. Oh well.
> 
> > LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html:29
> > +<li style="-webkit-box-reflect:below 5px -webkit-gradient(linear, left top, left bottom, from(transparent), color-stop(0.5, transparent), to(white));"></li>
> 
> You should use the unprefixed linear-gradient, like you did above.

OK I will do so.

> 
> > LayoutTests/css3/compositing/effect-background-blend-mode.html:16
> > +	background:  url("resources/ducky.png") no-repeat 0 0 /100% 100%, linear-gradient(to right, #00ffff 0%, rgba(0,0,255,0) 24%, #ff0000 50%, #ffff00 75%, #00ff00 100%);
> 
> Do we have the rights to this ducky image?

I believe so. I also used it in the compositing spec.
However, I will double check.

[Rik Cabanier]

Created attachment 187474 [details]
Patch

[WebKit Review Bot]

Attachment 187474 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html', u'LayoutTests/css3/compositing/effect-background-blend-mode.html', u'LayoutTests/css3/compositing/resources/ducky.png', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/cairo/ImageCairo.cpp', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/qt/ImageQt.cpp', u'Source/WebCore/platform/graphics/skia/ImageSkia.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp']" exit_code: 1
LayoutTests/platform/chromium/TestExpectations:145:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:146:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 187474 [details]
Patch

Attachment 187474 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16470786

New failing tests:
compositing/checkerboard.html
accessibility/anchor-linked-anonymous-block-crash.html
http/tests/cache/cancel-multiple-post-xhrs.html
animations/3d/state-at-end-event-transform.html
animations/animation-add-events-in-handler.html
animations/3d/replace-filling-transform.html
http/tests/cache/history-only-cached-subresource-loads.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
accessibility/accessibility-object-detached.html
accessibility/anonymous-render-block-in-continuation-causes-crash.html
animations/animation-controller-drt-api.html
compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/absolute-position-changed-in-composited-layer.html
http/tests/cache/iframe-304-crash.html
animations/3d/transform-perspective.html
http/tests/cache/cancel-during-failure-crash.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
canvas/philip/tests/2d.clearRect.basic.html
animations/3d/transform-origin-vs-functions.html
animations/animation-css-rule-types.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html

[Build Bot]

Comment on attachment 187474 [details]
Patch

Attachment 187474 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16531187

[Rik Cabanier]

Created attachment 188105 [details]
Patch

[WebKit Review Bot]

Attachment 188105 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt', u'LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html', u'LayoutTests/css3/compositing/effect-background-blend-mode.html', u'LayoutTests/css3/compositing/resources/ducky.png', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-expected.png', u'LayoutTests/platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratedImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/cairo/ImageCairo.cpp', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/qt/ImageQt.cpp', u'Source/WebCore/platform/graphics/skia/ImageSkia.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in']" exit_code: 1
LayoutTests/platform/chromium/TestExpectations:145:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:146:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 188105 [details]
Patch

Rejecting attachment 188105 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 188105, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
nning '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/chromium/TestExpectations:145:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:146:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 1 files

Full output: http://queues.webkit.org/results/16540882

[Rik Cabanier]

Created attachment 188454 [details]
Removed testexpectations from chromium

[WebKit Review Bot]

Attachment 188454 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rik Cabanier]

Created attachment 188455 [details]
patch

[Dean Jackson]

Rik, I can land the patch manually - just tell me which one.

[Rik Cabanier]

(In reply to comment #36)
> Rik, I can land the patch manually - just tell me which one.

I will try to change the expectations file and see if the chromium issue was fixed

[WebKit Review Bot]

Comment on attachment 188455 [details]
patch

Attachment 188455 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16581629

New failing tests:
svg/as-background-image/background-image-tiled.html
svg/zoom/page/zoom-background-image-tiled.html
svg/as-background-image/svg-as-tiled-background.html
svg/css/background-image-svg.html
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-border-image/svg-as-border-image-2.html

[Rik Cabanier]

Created attachment 188468 [details]
Patch

[WebKit Review Bot]

Comment on attachment 188468 [details]
Patch

Clearing flags on attachment: 188468

Committed r143046: <http://trac.webkit.org/changeset/143046>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.