Bug 108446 - [chromium] Rework page scale factor limits initialization
Summary: [chromium] Rework page scale factor limits initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on: 107922
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-31 02:26 PST by Alexandre Elias
Modified: 2013-01-31 14:03 PST (History)
4 users (show)

See Also:


Attachments
Patch (21.30 KB, patch)
2013-01-31 02:38 PST, Alexandre Elias
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2013-01-31 02:26:33 PST
[chromium] Rework page scale factor limits initialization
Comment 1 Alexandre Elias 2013-01-31 02:38:21 PST
Created attachment 185727 [details]
Patch
Comment 2 Adam Barth 2013-01-31 10:27:28 PST
Comment on attachment 185727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185727&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:3804
> +        if (view && view->needsLayout())
> +            view->layout();

Why doesn't this cause an infinite loop?
Comment 3 Alexandre Elias 2013-01-31 10:36:01 PST
Page scale factor limits are supposed to converge and it shouldn't set needsLayout() repeatedly.  What I expect to cause a layout right now is fixed-position element positioning, and that doesn't affect the inputs of computePageScaleFactorLimits.  If there's a bug and it doesn't converge, that would cause problems anyway and it's probably better to catch that issue via crash report than via reports of glitchniness or of very slow renderer due to repeated layout.
Comment 4 Alexandre Elias 2013-01-31 14:03:57 PST
Committed r141483: <http://trac.webkit.org/changeset/141483>