http://i.imgur.com/i8lcG92.png http://i.imgur.com/jyUHdxq.png http://i.imgur.com/sBwdHEA.png There are giant spikes on some patch waiting time graphs and linearly increasing data on others. It is not uncommon to see patch waiting times logged on the order of days. Single patch waiting time scatter plots don't always match up with the waiting times shown for the queue where particularly noticeable.
Created attachment 185751 [details] Patch
Attachment 185751 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/cron.yaml', u'Tools/QueueStatusServer/handlers/syncqueuelogs.py', u'Tools/QueueStatusServer/loggers/recordpatchevent.py', u'Tools/QueueStatusServer/main.py', u'Tools/QueueStatusServer/model/patchlog.py', u'Tools/QueueStatusServer/model/queuelog.py', u'Tools/QueueStatusServer/model/warninglog.py']" exit_code: 1 Tools/QueueStatusServer/model/warninglog.py:32: No name 'appengine' in module 'google' [pylint/E0611] [5] Tools/QueueStatusServer/model/warninglog.py:46: [WarningLog.record] Instance of 'WarningLog' has no 'put' member [pylint/E1101] [5] Tools/QueueStatusServer/handlers/syncqueuelogs.py:29: No name 'appengine' in module 'google' [pylint/E0611] [5] Tools/QueueStatusServer/handlers/syncqueuelogs.py:42: [SyncQueueLogs.get] Instance of 'SyncQueueLogs' has no 'response' member [pylint/E1101] [5] Tools/QueueStatusServer/model/patchlog.py:53: [PatchLog.lookup_if_exists] Class 'PatchLog' has no 'get_by_key_name' member [pylint/E1101] [5] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 185751 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/cron.yaml', u'Tools/QueueStatusServer/handlers/syncqueuelogs.py', u'Tools/QueueStatusServer/loggers/recordpatchevent.py', u'Tools/QueueStatusServer/main.py', u'Tools/QueueStatusServer/model/patchlog.py', u'Tools/QueueStatusServer/model/queuelog.py', u'Tools/QueueStatusServer/model/warninglog.py']" exit_code: 1 > Tools/QueueStatusServer/model/warninglog.py:32: No name 'appengine' in module 'google' [pylint/E0611] [5] > Tools/QueueStatusServer/model/warninglog.py:46: [WarningLog.record] Instance of 'WarningLog' has no 'put' member [pylint/E1101] [5] > Tools/QueueStatusServer/handlers/syncqueuelogs.py:29: No name 'appengine' in module 'google' [pylint/E0611] [5] > Tools/QueueStatusServer/handlers/syncqueuelogs.py:42: [SyncQueueLogs.get] Instance of 'SyncQueueLogs' has no 'response' member [pylint/E1101] [5] > Tools/QueueStatusServer/model/patchlog.py:53: [PatchLog.lookup_if_exists] Class 'PatchLog' has no 'get_by_key_name' member [pylint/E1101] [5] > Total errors found: 5 in 9 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Created bug 108463 to address this issue.
Comment on attachment 185751 [details] Patch LGTM.
Comment on attachment 185751 [details] Patch Clearing flags on attachment: 185751 Committed r141451: <http://trac.webkit.org/changeset/141451>
All reviewed patches have been landed. Closing bug.