Bug 108463 - check-webkit-style does not know about Google App Engine Python libraries
Summary: check-webkit-style does not know about Google App Engine Python libraries
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 05:07 PST by Alan Cutter
Modified: 2013-01-31 11:09 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Cutter 2013-01-31 05:07:25 PST 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/cron.yaml', u'Tools/QueueStatusServer/handlers/syncqueuelogs.py', u'Tools/QueueStatusServer/loggers/recordpatchevent.py', u'Tools/QueueStatusServer/main.py', u'Tools/QueueStatusServer/model/patchlog.py', u'Tools/QueueStatusServer/model/queuelog.py', u'Tools/QueueStatusServer/model/warninglog.py']" exit_code: 1
> Tools/QueueStatusServer/model/warninglog.py:32:  No name 'appengine' in module 'google'  [pylint/E0611] [5]
> Tools/QueueStatusServer/model/warninglog.py:46:  [WarningLog.record] Instance of 'WarningLog' has no 'put' member  [pylint/E1101] [5]
> Tools/QueueStatusServer/handlers/syncqueuelogs.py:29:  No name 'appengine' in module 'google'  [pylint/E0611] [5]
> Tools/QueueStatusServer/handlers/syncqueuelogs.py:42:  [SyncQueueLogs.get] Instance of 'SyncQueueLogs' has no 'response' member  [pylint/E1101] [5]
> Tools/QueueStatusServer/model/patchlog.py:53:  [PatchLog.lookup_if_exists] Class 'PatchLog' has no 'get_by_key_name' member  [pylint/E1101] [5]
> Total errors found: 5 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 1 Eric Seidel (no email) 2013-01-31 11:09:27 PST 
I looked into auto-installing GAE.  I just never finished the patch when I tried a couple days ago.  Should be absolutely trivial.

I worry we're installing too many things at this point... but the solution to that is to just make only the ones we need autointall when we need them (which of course is all of them for running test-webkitpy).