Bug 108301 - getDecorationRootAndDecoratedRoot should add new user agent shadow roots
Summary: getDecorationRootAndDecoratedRoot should add new user agent shadow roots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on: 108209
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-30 00:27 PST by Elliott Sprehn
Modified: 2013-01-30 01:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2013-01-30 00:47 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-01-30 00:27:23 PST 
getDecorationRootAndDecoratedRoot should add new user agent shadow roots
Comment 1 Elliott Sprehn 2013-01-30 00:47:25 PST 
Created attachment 185418 [details]
Patch
Comment 2 Hajime Morrita 2013-01-30 00:52:13 PST 
Comment on attachment 185418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185418&action=review

> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:98
> +        // the input.

Yeah, adding UA shadow root is basically a bad idea and the team tried to get rid of it. This one has been overlooked though.
Comment 3 WebKit Review Bot 2013-01-30 01:43:05 PST 
Comment on attachment 185418 [details]
Patch

Clearing flags on attachment: 185418

Committed r141235: <http://trac.webkit.org/changeset/141235>
Comment 4 WebKit Review Bot 2013-01-30 01:43:08 PST 
All reviewed patches have been landed.  Closing bug.