Bug 108209 – Refactor ShadowRoot exception handling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Elliott Sprehn]

Refactor ShadowRoot exception handling

[Elliott Sprehn]

Created attachment 185275 [details]
Patch

[Early Warning System Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16195241

[Early Warning System Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16187316

[EFL EWS Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16151309

[WebKit Review Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16151315

[Elliott Sprehn]

Woops, it seems we do ShadowRoot::create in a bunch of places I missed.

[Build Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16198259

[Peter Beverloo (cr-android ews)]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16200266

[Build Bot]

Comment on attachment 185275 [details]
Patch

Attachment 185275 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16202258

[Elliott Sprehn]

Created attachment 185283 [details]
Patch

[Elliott Sprehn]

(In reply to comment #10)
> Created an attachment (id=185283) [details]
> Patch

Fixed the build, should be good for review now.

[Build Bot]

Comment on attachment 185283 [details]
Patch

Attachment 185283 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16183293

[Build Bot]

Comment on attachment 185283 [details]
Patch

Attachment 185283 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16200292

[Elliott Sprehn]

Created attachment 185292 [details]
Patch

Exports, yay.

[Build Bot]

Comment on attachment 185292 [details]
Patch

Attachment 185292 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16183309

[Build Bot]

Comment on attachment 185292 [details]
Patch

Attachment 185292 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16198296

[Elliott Sprehn]

Created attachment 185300 [details]
Patch

More exporting.

[Elliott Sprehn]

Created attachment 185306 [details]
Patch

[Elliott Sprehn]

Created attachment 185319 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185319 [details]
Patch

Clearing flags on attachment: 185319

Committed r141175: <http://trac.webkit.org/changeset/141175>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Elliott Sprehn]

Reading the code more closely it appears this patch should have broken TextFieldDecorationElement because it intended to actually create multiple user agent shadow roots!??

Unfortunately there's no layout tests for this code, in fact TextFieldDecorationElement is only used in ChromeClientImpl::addTextFieldDecorationsTo which seems really bad that we have magical elements and hacks in WebCore that are specifically for Chromium and then have no tests in WebCore for them.

[Elliott Sprehn]

(In reply to comment #22)
> Reading the code more closely it appears this patch should have broken TextFieldDecorationElement because it intended to actually create multiple user agent shadow roots!??
> 
> Unfortunately there's no layout tests for this code, in fact TextFieldDecorationElement is only used in ChromeClientImpl::addTextFieldDecorationsTo which seems really bad that we have magical elements and hacks in WebCore that are specifically for Chromium and then have no tests in WebCore for them.

https://bugs.webkit.org/show_bug.cgi?id=108301