Bug 108213 – [Qt] HTML5 video - sound volume bar out of widget

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Another regression since qtwebkit 2.2. Sound volume bar is often displaced and out of the video widget. Also, If browser supports directly opening of the media, after video plays to the end it disappears.

Page for testing: http://www.w3schools.com/html/tryit.asp?filename=tryhtml5_video_all

Some screenshots of the issue:

1. http://s7.postimage.org/kzo5oesaz/sbissue1.png
2. http://s1.postimage.org/h5isrnysf/sbissue2.png
3. http://s8.postimage.org/ncvzfjuzn/sbissue3.png

Picture nr. 3 is the situation where the video would disappear after playing to the end.

[Allan Sandfeld Jensen]

This is not specific to QtWebKit 2.3. I can reproduce the same issue in trunk with Qt5.

[Allan Sandfeld Jensen]

Created attachment 185732 [details]
Patch

[David Rosca]

Created attachment 185752 [details]
Fixes issue also for media files url's

[David Rosca]

The patch doesn't fix the issue on: http://www.w3schools.com/html/movie.mp4
My patch fixes it.

Confirming, David's patch fixed the sound volume bar.

[Allan Sandfeld Jensen]

Created attachment 188840 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 188840 [details]
Patch

Untagging for review. The underlying issue seems to be we use the Apple MediaControl shadow DOM, but with our own CSS and set of buttons. 

All these patch attempts does is work around the wrong underlying shadow DOM tree.

[Allan Sandfeld Jensen]

Created attachment 188914 [details]
Patch

Another attempt, this time following Apple CSS, but keeping our style.

[Jocelyn Turcotte]

Comment on attachment 188914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188914&action=review

I can't say that those coordinates all makes sense to me, but I tested the patch and it's definitely an improvement.

> Source/WebCore/css/mediaControlsQt.css:39
>      bottom: 0px;

This line is already in mediaControls.css, you should be able to remove it.

[Allan Sandfeld Jensen]

Committed r145214: <http://trac.webkit.org/changeset/145214>