Bug 107958 - Loosen restrictions on computePreferredLogicalWidths in RenderQuote and RenderCounter
Summary: Loosen restrictions on computePreferredLogicalWidths in RenderQuote and Rende...
Status: RESOLVED DUPLICATE of bug 104829
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
: 107913 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-25 09:51 PST by Ojan Vafai
Modified: 2013-01-25 11:03 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2013-01-25 09:53 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-25 09:51:40 PST 
Loosen restrictions on computePreferredLogicalWidths in RenderQuote and RenderCounter
Comment 1 Ojan Vafai 2013-01-25 09:53:27 PST 
Created attachment 184769 [details]
Patch
Comment 2 Ojan Vafai 2013-01-25 09:54:09 PST 
*** Bug 107913 has been marked as a duplicate of this bug. ***
Comment 3 Julien Chaffraix 2013-01-25 10:08:03 PST 
Comment on attachment 184769 [details]
Patch

There is a patch to add pre-layout hooks that would just remove the need for these hacks (at least for RenderCounter, RenderQuote would be next in line). I would rather not land this patch and just go the pre-layout hooks way (see bug 104829).
Comment 4 Ojan Vafai 2013-01-25 10:13:34 PST 
(In reply to comment #3)
> (From update of attachment 184769 [details])
> There is a patch to add pre-layout hooks that would just remove the need for these hacks (at least for RenderCounter, RenderQuote would be next in line). I would rather not land this patch and just go the pre-layout hooks way (see bug 104829).

Bug 104629 addresses the FIXME and can remove it. In the meantime, we currently are hitting an assert. Once bug 104629 lands, we can remove this. What's the benefit of leaving the code in it's current state? We have a test that is hitting this the setNeedsLayoutIsForbidden assert that we need to do *something* with.

IMO, this effectively documents the places where we need the pre-layout hooks.
Comment 5 Ojan Vafai 2013-01-25 10:58:11 PST 
Comment on attachment 184769 [details]
Patch

Looks like Julien's patch is ready to land and will fix the RenderCounter issue. We don't currently have a test that hits the RenderQuote issue, so I'm not too bothered about putting the assert guards there. Hopefully, we can migrate the RenderQuote code shortly to use the pre-layout hook.
Comment 6 Ojan Vafai 2013-01-25 11:03:08 PST 

*** This bug has been marked as a duplicate of bug 104829 ***