Bug 107923 – [EFL][WK2] Use C API inside ewk_security_origin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

As per Bug 107657, we should start using the C API internally to avoid violating layering.

[Chris Dumez]

Created attachment 184685 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 184685 [details]
Patch

LGTM

[Mikhail Pozdnyakov]

Comment on attachment 184685 [details]
Patch

Looks nice.

[Simon Hausmann]

Comment on attachment 184685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review

LGTM

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450
> +    RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url);

Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps?

[Simon Hausmann]

Comment on attachment 184685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450
>> +    RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url);
> 
> Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps?

To elaborate a bit: What I meant to say was that it depends on in which "direction" m_url is used towards, outside towards the developer using WebKit or inside into the WK2 layer. For the latter in Qt we added an optimization that allows us to create a WTFString practically for free from a QString without a copy. That makes WKStringRef creation from QString in turn also cheaper as it avoids data copying. A similar pattern might (or might not) make sense for Efl :)

[Chris Dumez]

Comment on attachment 184685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review

>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450
>>> +    RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url);
>> 
>> Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps?
> 
> To elaborate a bit: What I meant to say was that it depends on in which "direction" m_url is used towards, outside towards the developer using WebKit or inside into the WK2 layer. For the latter in Qt we added an optimization that allows us to create a WTFString practically for free from a QString without a copy. That makes WKStringRef creation from QString in turn also cheaper as it avoids data copying. A similar pattern might (or might not) make sense for Efl :)

m_url is exposed to the client so we keep it as a char* (which is actually an eina stringshare). This is the only place when m_url is eventually converted into a WKStringRef and this only happens when entering fullscreen with fullscreen API so this does not happen frequently.

[WebKit Review Bot]

Comment on attachment 184685 [details]
Patch

Clearing flags on attachment: 184685

Committed r143258: <http://trac.webkit.org/changeset/143258>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.