Bug 107907 - Support language WebVTT Nodes
Summary: Support language WebVTT Nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dima Gorbik
URL:
Keywords: InRadar
Depends on:
Blocks: 43668
  Show dependency tree / graph
 
Reported: 2013-01-24 20:41 PST by Dima Gorbik
Modified: 2013-01-25 16:22 PST (History)
8 users (show)

See Also:

Attachments
Proposed fix 0.1 (10.94 KB, patch)
2013-01-24 21:00 PST, Dima Gorbik 		koivisto: review+
Details | Formatted Diff | Diff
Proposed fix 0.2 (11.00 KB, patch)
2013-01-25 15:46 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Gorbik 2013-01-24 20:41:12 PST 
Language WebVTT nodes are used to define a language for children objects without implying further meaning (such as italics or bold)
Comment 1 Radar WebKit Bug Importer 2013-01-24 20:59:00 PST 
<rdar://problem/13084183>
Comment 2 Radar WebKit Bug Importer 2013-01-24 20:59:03 PST 
<rdar://problem/13084184>
Comment 3 Dima Gorbik 2013-01-24 21:00:00 PST 
Created attachment 184651 [details]
Proposed fix 0.1
Comment 4 Antti Koivisto 2013-01-25 01:59:43 PST 
Comment on attachment 184651 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=184651&action=review

> Source/WebCore/html/track/WebVTTParser.cpp:345
> +inline bool isLangToken(WebVTTToken& token)

static inline

> Source/WebCore/html/track/WebVTTParser.h:136
> +    Vector<AtomicString> languageStack;

m_languageStack
Comment 5 Dima Gorbik 2013-01-25 15:46:06 PST 
Created attachment 184822 [details]
Proposed fix 0.2
Comment 6 Eric Carlson 2013-01-25 16:06:52 PST 
Comment on attachment 184822 [details]
Proposed fix 0.2

Marking r+ based on antti's earlier review.
Comment 7 WebKit Review Bot 2013-01-25 16:22:17 PST 
Comment on attachment 184822 [details]
Proposed fix 0.2

Clearing flags on attachment: 184822

Committed r140877: <http://trac.webkit.org/changeset/140877>
Comment 8 WebKit Review Bot 2013-01-25 16:22:21 PST 
All reviewed patches have been landed.  Closing bug.