Bug 107889 - [chromium] Remove dead transitional code from WebViewImpl
Summary: [chromium] Remove dead transitional code from WebViewImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 107932
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-24 17:57 PST by James Robinson
Modified: 2013-01-31 09:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2013-01-24 17:57 PST, James Robinson 		no flags Details | Formatted Diff | Diff
moar nomnomnoms (10.70 KB, patch)
2013-01-24 18:15 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (13.02 KB, patch)
2013-01-30 17:23 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-01-24 17:57:01 PST 
[chromium] Remove dead transitional code from WebViewImpl
Comment 1 James Robinson 2013-01-24 17:57:57 PST 
Created attachment 184624 [details]
Patch
Comment 2 Adrienne Walker 2013-01-24 18:01:21 PST 
Comment on attachment 184624 [details]
Patch

R+++++++++++, would R+ again.
Comment 3 James Robinson 2013-01-24 18:15:34 PST 
Created attachment 184629 [details]
moar nomnomnoms
Comment 4 James Robinson 2013-01-24 18:17:12 PST 
(In reply to comment #2)
> (From update of attachment 184624 [details])
> R+++++++++++, would R+ again.

Added some more, PTAL.  After this, some of this interface can start being removed from WebLayerTreeView completely.
Comment 5 WebKit Review Bot 2013-01-24 18:20:34 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 6 Adrienne Walker 2013-01-24 18:49:44 PST 
Comment on attachment 184629 [details]
moar nomnomnoms

R=me.
Comment 7 WebKit Review Bot 2013-01-24 20:58:28 PST 
Comment on attachment 184629 [details]
moar nomnomnoms

Clearing flags on attachment: 184629

Committed r140774: <http://trac.webkit.org/changeset/140774>
Comment 8 WebKit Review Bot 2013-01-24 20:58:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2013-01-25 02:59:27 PST 
Re-opened since this is blocked by bug 107932
Comment 10 Keishi Hattori 2013-01-25 03:01:08 PST 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&testType=webkit_unit_tests&tests=ScrollingCoordinatorChromiumTest.fastScrollingByDefault,ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
Comment 11 James Robinson 2013-01-25 16:58:36 PST 
(In reply to comment #10)
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&testType=webkit_unit_tests&tests=ScrollingCoordinatorChromiumTest.fastScrollingByDefault,ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition

Sorry for breaking this!  Looks like this patch breaks some of the webkit_unit_tests that only run in static builds, not component, and I forgot to test that configuration.  Will figure out and post an updated patch...
Comment 12 James Robinson 2013-01-30 17:23:22 PST 
Created attachment 185632 [details]
Patch
Comment 13 Adam Barth 2013-01-30 23:53:04 PST 
Comment on attachment 185632 [details]
Patch

rs=me based on enne's comments above.
Comment 14 WebKit Review Bot 2013-01-31 09:45:42 PST 
Comment on attachment 185632 [details]
Patch

Clearing flags on attachment: 185632

Committed r141428: <http://trac.webkit.org/changeset/141428>
Comment 15 WebKit Review Bot 2013-01-31 09:45:46 PST 
All reviewed patches have been landed.  Closing bug.