Bug 107854 - [WK2][EFL] PagePolicyClientEfl should be based on C WK2 API
Summary: [WK2][EFL] PagePolicyClientEfl should be based on C WK2 API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 107657
  Show dependency tree / graph
 
Reported: 2013-01-24 12:36 PST by Mikhail Pozdnyakov
Modified: 2013-01-25 02:46 PST (History)
7 users (show)

See Also:

Attachments
patch (3.68 KB, patch)
2013-01-24 13:24 PST, Mikhail Pozdnyakov 		benjamin: review+
Details | Formatted Diff | Diff
patch v2 (3.63 KB, patch)
2013-01-25 01:14 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-01-24 12:36:37 PST 
SSIA
Comment 1 Mikhail Pozdnyakov 2013-01-24 13:24:59 PST 
Created attachment 184567 [details]
patch
Comment 2 Chris Dumez 2013-01-24 13:42:06 PST 
Comment on attachment 184567 [details]
patch

LGTM.
Comment 3 Benjamin Poulain 2013-01-24 13:59:35 PST 
Comment on attachment 184567 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184567&action=review

> Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.cpp:94
> +    bool isXMLType = WKStringIsEqualToUTF8CStringIgnoringCase(mimeType.get(), "text/xml") || WKStringIsEqualToUTF8CStringIgnoringCase(mimeType.get(), "application/xml");

Using the "IgnoringCase" here seems unnecessary. If ResourceResponse starts returning uppercase mimetype, it would break WebCore.
Comment 4 Mikhail Pozdnyakov 2013-01-25 01:14:35 PST 
Created attachment 184694 [details]
patch v2

removed "ignoring case"
Comment 5 WebKit Review Bot 2013-01-25 02:46:40 PST 
Comment on attachment 184694 [details]
patch v2

Clearing flags on attachment: 184694

Committed r140806: <http://trac.webkit.org/changeset/140806>
Comment 6 WebKit Review Bot 2013-01-25 02:46:44 PST 
All reviewed patches have been landed.  Closing bug.