Bug 107826 – [EFL][WK2] Use C API inside ewk_url_response

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 184490 [details]
Patch

[Chris Dumez]

Comment on attachment 184490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184490&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_url_response_private.h:-58
> -    explicit EwkUrlResponse(const WebCore::ResourceResponse& coreResponse);

We should probably stop including <WebCore/ResourceResponse.h> then.

[Kenneth Rohde Christiansen]

Created attachment 184496 [details]
Patch

[Chris Dumez]

Comment on attachment 184496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review

> Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);

Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).

[Kenneth Rohde Christiansen]

(In reply to comment #4)
> (From update of attachment 184496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review
> 
> > Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> > +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);
> 
> Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).

I will change it to that... contents vs content is something I never get right :-) and I am not the only one if you grep for those in WebKit!

[Kenneth Rohde Christiansen]

Created attachment 184504 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 184504 [details]
Patch

LGTM

[Andreas Kling]

Comment on attachment 184504 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 184504 [details]
Patch

Clearing flags on attachment: 184504

Committed r140962: <http://trac.webkit.org/changeset/140962>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.