Bug 107826 - [EFL][WK2] Use C API inside ewk_url_response
Summary: [EFL][WK2] Use C API inside ewk_url_response
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 107657
  Show dependency tree / graph
 
Reported: 2013-01-24 07:29 PST by Kenneth Rohde Christiansen
Modified: 2013-01-28 02:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2013-01-24 07:32 PST, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2013-01-24 07:58 PST, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2013-01-24 08:16 PST, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2013-01-24 07:29:57 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2013-01-24 07:32:28 PST 
Created attachment 184490 [details]
Patch
Comment 2 Chris Dumez 2013-01-24 07:45:33 PST 
Comment on attachment 184490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184490&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_url_response_private.h:-58
> -    explicit EwkUrlResponse(const WebCore::ResourceResponse& coreResponse);

We should probably stop including <WebCore/ResourceResponse.h> then.
Comment 3 Kenneth Rohde Christiansen 2013-01-24 07:58:34 PST 
Created attachment 184496 [details]
Patch
Comment 4 Chris Dumez 2013-01-24 08:04:31 PST 
Comment on attachment 184496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review

> Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);

Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).
Comment 5 Kenneth Rohde Christiansen 2013-01-24 08:13:24 PST 
(In reply to comment #4)
> (From update of attachment 184496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184496&action=review
> 
> > Source/WebKit2/Shared/API/c/WKURLResponse.h:47
> > +WK_EXPORT uint32_t WKURLResponseGetExpectedContentsLength(WKURLResponseRef);
> 
> Sorry I did not see this earlier but why contents (plural)?  The HTTP header field is "Content-Length" (singular). Also note that WebCore and the EFL API both use Content (singular).

I will change it to that... contents vs content is something I never get right :-) and I am not the only one if you grep for those in WebKit!
Comment 6 Kenneth Rohde Christiansen 2013-01-24 08:16:37 PST 
Created attachment 184504 [details]
Patch
Comment 7 Mikhail Pozdnyakov 2013-01-24 12:20:26 PST 
Comment on attachment 184504 [details]
Patch

LGTM
Comment 8 Andreas Kling 2013-01-28 02:16:17 PST 
Comment on attachment 184504 [details]
Patch

r=me
Comment 9 WebKit Review Bot 2013-01-28 02:33:23 PST 
Comment on attachment 184504 [details]
Patch

Clearing flags on attachment: 184504

Committed r140962: <http://trac.webkit.org/changeset/140962>
Comment 10 WebKit Review Bot 2013-01-28 02:33:28 PST 
All reviewed patches have been landed.  Closing bug.