Bug 107660 - [GTK][WK2] Tests related to layoutTestController.setViewModeMediaFeature are passing
Summary: [GTK][WK2] Tests related to layoutTestController.setViewModeMediaFeature are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 03:52 PST by Manuel Rego Casasnovas
Modified: 2013-01-23 10:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2013-01-23 03:58 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-01-23 03:52:11 PST
However, they're marked as Failure at LayoutTests/platform/gtk-wk2/TestExpectations:

# Implement layoutTestController.setViewModeMediaFeature support 
Bug(GTK) fast/media/media-query-list-02.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-03.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-04.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-05.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-06.html [ Failure ] 
Bug(GTK) fast/media/media-query-list-07.html [ Failure ] 
Bug(GTK) fast/media/view-mode-media-feature.html [ Failure ]
Comment 1 Manuel Rego Casasnovas 2013-01-23 03:57:41 PST
layoutTestController.setViewModeMediaFeature was implemented in bug #103886

http://trac.webkit.org/changeset/137148
Comment 2 Manuel Rego Casasnovas 2013-01-23 03:58:31 PST
Created attachment 184196 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-23 10:50:02 PST
Comment on attachment 184196 [details]
Patch

Clearing flags on attachment: 184196

Committed r140550: <http://trac.webkit.org/changeset/140550>
Comment 4 WebKit Review Bot 2013-01-23 10:50:06 PST
All reviewed patches have been landed.  Closing bug.