are skipped because WebKitTestRunner lacks method setViewModeMediaFeature().
Created attachment 177428 [details]
Comment on attachment 177428 [details]
Attachment 177428 [details] did not pass mac-ews (mac):
Created attachment 177710 [details]
Comment on attachment 177710 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=177710&action=review
> + Unskipping the following tests:
... for EFL WebKit2.
> + Export WebCore::Page::setViewMode method to WebKit(2).
"Export symbol for WebCore::Page::setViewMode on Mac." ?
> + No new tests (OOPS!).
You should indicate something like:
"No new tests, no behavior change for layout tests."
> + WebCore::Page* page = toImpl(pageRef)->corePage();
It is uncommon to access the WebCore page from WKBundlePage I believe. I would usually add a new method to WebPage and call that one from WKBundlePage. WKBundlePage is usually just a C wrapper around WebPage API.
> + page->setViewMode(WebCore::Page::ViewModeMinimized);
Maybe an ASSERT_NOT_REACHED(); at this end of this function just in case?
> +WK_EXPORT void WKBundlePageSetViewMode(WKBundlePageRef pageRef, WKStringRef mode);
Unless there is a specific need to this to be public, it should probably go to WKBundlePagePrivate.h. At least so far it is used by WKTR only.
> + [WK2][WTR] Enable view mode media feature layout test
"Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner" may be a better title.
> + InjectedBundle API extended to set view mode media feature.
"Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner." ?
Created attachment 177731 [details]
Comment on attachment 177731 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=177731&action=review
> + which are going to be unskipped in bug #103886.
I would remove this line since this is the same bug.
Unneeded blank line
> +void WebPage::setViewMode(WebCore::Page::ViewMode mode)
You do not need WebCore:: here.
Created attachment 177732 [details]
Comment on attachment 177732 [details]
Rejecting attachment 177732 [details] from commit-queue.
Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
Last 500 characters of output:
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Hunk #1 succeeded at 882 (offset -2 lines).
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue
Full output: http://queues.webkit.org/results/15219894
Created attachment 178521 [details]
There was a Changelog conflict, this patch fixes it.
Comment on attachment 178521 [details]
Clearing flags on attachment: 178521
Committed r137148: <http://trac.webkit.org/changeset/137148>
All reviewed patches have been landed. Closing bug.
*** Bug 104148 has been marked as a duplicate of this bug. ***