Bug 107652 – [WK2] Replace some internal API usage in EwkView with C API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 184183 [details]
Patch

[Chris Dumez]

Comment on attachment 184183 [details]
Patch

LGTM.

[Gyuyoung Kim]

Comment on attachment 184183 [details]
Patch

Looks fine.

[Benjamin Poulain]

Comment on attachment 184183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184183&action=review

Really nice.

Just one API thingy you might want to look into:

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:758
> -    if (unreachableUrl && *unreachableUrl)
> -        impl->page()->loadAlternateHTMLString(String::fromUTF8(html), baseUrl ? String::fromUTF8(baseUrl) : "", String::fromUTF8(unreachableUrl));
> -    else
> -        impl->page()->loadHTMLString(String::fromUTF8(html), baseUrl ? String::fromUTF8(baseUrl) : "");
> +    WKRetainPtr<WKStringRef> wkHTMLString = adoptWK(WKStringCreateWithUTF8CString(html));
> +    WKRetainPtr<WKURLRef> wkBaseURL = adoptWK(WKURLCreateWithUTF8CString(baseUrl));
> +
> +    if (unreachableUrl && *unreachableUrl) {
> +        WKRetainPtr<WKURLRef> wkUnreachableURL = adoptWK(WKURLCreateWithUTF8CString(unreachableUrl));
> +        WKPageLoadAlternateHTMLString(impl->wkPage(), wkHTMLString.get(), wkBaseURL.get(), wkUnreachableURL.get());
> +    } else
> +        WKPageLoadHTMLString(impl->wkPage(), wkHTMLString.get(), wkBaseURL.get());

The new code is nicer than the old one.

[Benjamin Poulain]

Comment on attachment 184183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184183&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:568
> -    impl->page()->loadURL(url);
> +    WKRetainPtr<WKURLRef> wkUrl = adoptWK(WKURLCreateWithUTF8CString(url));
> +    WKPageLoadURL(impl->wkPage(), wkUrl.get());

This change the behavior. You know supports UTF8 instead of Latin1.
You may want to update the documentation and tests.

[Kenneth Rohde Christiansen]

Created #107739 to track the unit test and documentation update.

[WebKit Review Bot]

Comment on attachment 184183 [details]
Patch

Clearing flags on attachment: 184183

Committed r140600: <http://trac.webkit.org/changeset/140600>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.