Bug 107598 - Remove webkitNotifications.createHTMLNotification
Summary: Remove webkitNotifications.createHTMLNotification
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords: InRadar, WebExposed
Depends on: 108277
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-22 16:40 PST by Adam Barth
Modified: 2024-02-18 16:51 PST (History)
12 users (show)

See Also:

Attachments
Patch (36.92 KB, patch)
2013-01-22 16:46 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (41.33 KB, patch)
2013-01-22 17:08 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (43.16 KB, patch)
2013-01-28 11:14 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-01-22 16:40:44 PST 
Remove webkitNotifications.createHTMLNotification
Comment 1 Adam Barth 2013-01-22 16:46:01 PST 
Created attachment 184076 [details]
Patch
Comment 2 Benjamin Poulain 2013-01-22 16:56:06 PST 
Comment on attachment 184076 [details]
Patch

Wooot! :)
Comment 3 Early Warning System Bot 2013-01-22 17:03:48 PST 
Comment on attachment 184076 [details]
Patch

Attachment 184076 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16037874
Comment 4 Early Warning System Bot 2013-01-22 17:05:45 PST 
Comment on attachment 184076 [details]
Patch

Attachment 184076 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16037876
Comment 5 Adam Barth 2013-01-22 17:08:37 PST 
Created attachment 184086 [details]
Patch for landing
Comment 6 Adam Barth 2013-01-22 17:36:03 PST 
See https://code.google.com/p/chromium/issues/detail?id=137297

I'm going to wait a couple days before landing this patch.
Comment 7 WebKit Review Bot 2013-01-22 18:24:45 PST 
Comment on attachment 184086 [details]
Patch for landing

Attachment 184086 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16037901

New failing tests:
fast/notifications/notifications-with-permission.html
Comment 8 Ojan Vafai 2013-01-22 19:22:46 PST 
Looks like there's a test you need to update.
Comment 9 Adam Barth 2013-01-22 20:35:29 PST 
Yep.  I'll take care of it when I land the patch.
Comment 10 Radar WebKit Bug Importer 2013-01-22 22:44:54 PST 
<rdar://problem/13067995>
Comment 11 Adam Barth 2013-01-28 11:14:55 PST 
Created attachment 185018 [details]
Patch for landing
Comment 12 Adam Barth 2013-01-28 11:24:35 PST 
Committed r140983: <http://trac.webkit.org/changeset/140983>
Comment 13 WebKit Review Bot 2013-01-29 18:26:38 PST 
Re-opened since this is blocked by bug 108277
Comment 14 Ahmad Saleem 2024-02-18 16:51:22 PST 
Legacy Notifications gone - https://github.com/WebKit/WebKit/commit/34d6c0d0c6a163321646de3e58e9e2dee5f9d739

Nothing to do here.