Bug 107574 – style-bot should reject Committer additions to committers.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

style-bot should reject Committer additions to committers.py

This comes up rather frequently with everyone using the CQ these days, no one actually knows (or really needs to know) how to commit.  But it remains important to do your first commit yourself, to prove that Apple actually received, acknowledged your contract with them, and blessed your account.

bug 107546 is the most recent example.

Should be very easy to do.

[Alexey Proskuryakov]

Good idea!

[Tamas Gergely]

Created attachment 216374 [details]
Checks for modification of contributors.json

The listing of contributors seems to be changed since this bug had been reported. Now the list is in the contributors.json file.

I attached a first-version patch, could you please comment it?

[Peter Gal]

Comment on attachment 216374 [details]
Checks for modification of contributors.json

View in context: https://bugs.webkit.org/attachment.cgi?id=216374&action=review

> Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:57
> +#        if _called_from_bot:

I don't think this line is needed :)

[Peter Gal]

(In reply to comment #2)
> I attached a first-version patch, could you please comment it?

Maybe adding r? && cq? would be good.

[Tamas Gergely]

Created attachment 216554 [details]
Checks for modification of contributors.json on bots.

[Peter Gal]

LGTM

[Tamas Gergely]

Created attachment 218284 [details]
patch adds contributors.json style checker.

Patch updated.

[Zoltan Herczeg]

Comment on attachment 218284 [details]
patch adds contributors.json style checker.

r=me
Nice feature!

[WebKit Commit Bot]

Comment on attachment 218284 [details]
patch adds contributors.json style checker.

Clearing flags on attachment: 218284

Committed r160083: <http://trac.webkit.org/changeset/160083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.