WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
107546
Add myself to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=107546
Summary
Add myself to commiters.py
Eugene Klyuchnikov
Reported
2013-01-22 03:54:39 PST
Add myself to commiters.py
Attachments
Patch
(1.39 KB, patch)
2013-01-22 03:55 PST
,
Eugene Klyuchnikov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1
2013-01-22 03:55:50 PST
Created
attachment 183956
[details]
Patch
Kentaro Hara
Comment 2
2013-01-22 04:01:13 PST
Comment on
attachment 183956
[details]
Patch congrats!
WebKit Review Bot
Comment 3
2013-01-22 04:40:20 PST
Comment on
attachment 183956
[details]
Patch Rejecting
attachment 183956
[details]
from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output:
http://queues.webkit.org/results/16035567
WebKit Review Bot
Comment 4
2013-01-22 05:44:40 PST
Comment on
attachment 183956
[details]
Patch Clearing flags on attachment: 183956 Committed
r140418
: <
http://trac.webkit.org/changeset/140418
>
WebKit Review Bot
Comment 5
2013-01-22 05:44:44 PST
All reviewed patches have been landed. Closing bug.
Peter Beverloo
Comment 6
2013-01-22 09:00:47 PST
Mind that using the commit queue for introducing new committers to committers.py is generally frowned upon. Instead, this should have been committed manually, which also verifies that all the paperwork has been signed, received by Apple and all necessary rights have been set. With your first commit being less than two months ago, you ramped up really quickly. Assuming everything's alright, congratulations!
Alexey Proskuryakov
Comment 7
2013-01-22 10:05:10 PST
Rolled out in <
http://trac.webkit.org/r140434
>. Using commit-queue to make oneself a committer is not just frowned upon, it is wrong.
Eric Seidel (no email)
Comment 8
2013-01-22 11:13:42 PST
Sorry this is so confusing. Filed
bug 107574
about making it less so.
Eugene Klyuchnikov
Comment 9
2013-01-28 04:32:31 PST
I've been submitting patches since May'12 (under eustas.bug account). I've been successfully nominated for WebKit Committer status and sent the committer agreement six weeks ago.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug