Bug 107546 - Add myself to commiters.py
Summary: Add myself to commiters.py
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 03:54 PST by Eugene Klyuchnikov
Modified: 2013-01-28 04:44 PST (History)
16 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2013-01-22 03:55 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-01-22 03:54:39 PST 
Add myself to commiters.py
Comment 1 Eugene Klyuchnikov 2013-01-22 03:55:50 PST 
Created attachment 183956 [details]
Patch
Comment 2 Kentaro Hara 2013-01-22 04:01:13 PST 
Comment on attachment 183956 [details]
Patch

congrats!
Comment 3 WebKit Review Bot 2013-01-22 04:40:20 PST 
Comment on attachment 183956 [details]
Patch

Rejecting attachment 183956 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/16035567
Comment 4 WebKit Review Bot 2013-01-22 05:44:40 PST 
Comment on attachment 183956 [details]
Patch

Clearing flags on attachment: 183956

Committed r140418: <http://trac.webkit.org/changeset/140418>
Comment 5 WebKit Review Bot 2013-01-22 05:44:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Peter Beverloo 2013-01-22 09:00:47 PST 
Mind that using the commit queue for introducing new committers to committers.py is generally frowned upon.  Instead, this should have been committed manually, which also verifies that all the paperwork has been signed, received by Apple and all necessary rights have been set.

With your first commit being less than two months ago, you ramped up really quickly.  Assuming everything's alright, congratulations!
Comment 7 Alexey Proskuryakov 2013-01-22 10:05:10 PST 
Rolled out in <http://trac.webkit.org/r140434>. Using commit-queue to make oneself a committer is not just frowned upon, it is wrong.
Comment 8 Eric Seidel (no email) 2013-01-22 11:13:42 PST 
Sorry this is so confusing.  Filed bug 107574 about making it less so.
Comment 9 Eugene Klyuchnikov 2013-01-28 04:32:31 PST 
I've been submitting patches since May'12 (under eustas.bug account).
I've been successfully nominated for WebKit Committer status and sent the committer agreement six weeks ago.