getTopLevelPath from Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp will be needed in Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp too (see bug #107538). So the function should be moved to a utilities file in order to share the code.
Created attachment 183948 [details] Patch
Comment on attachment 183948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183948&action=review > Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:36 > +#include "InjectedBundleUtilities.h" > + > #include <fontconfig/fontconfig.h> There should be no newline gap here between system includes and relative includes. > Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:37 > +namespace Util { Probably the WTR namespace is enough and you can avoid the Util namespace. > Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:48 > +/** > + * Returns the top level directory from WEBKIT_TOP_LEVEL environment > + * variable. > + * > + * If the environment variable wasn't provided then assume we were built > + * into WebKitBuild/Debug or WebKitBuild/Release. Obviously this will fail > + * if the build directory is non-standard, but we can't do much more about > + * this. > + * > + * @return the top level path. > + */ > +CString topLevelPath(); We don't typically add gtkdoc comments for non-API methods.
Created attachment 184985 [details] Patch
Comment on attachment 184985 [details] Patch Clearing flags on attachment: 184985 Committed r140969: <http://trac.webkit.org/changeset/140969>
All reviewed patches have been landed. Closing bug.