Bug 107538 - [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated
Summary: [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 107541
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-22 02:45 PST by Manuel Rego Casasnovas
Modified: 2013-01-28 08:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.14 KB, patch)
2013-01-22 03:31 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2013-01-28 08:14 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-01-22 02:45:39 PST
Following tests are failing due to this reason:
* fast/loader/local-CSS-from-local.html
* fast/loader/local-JavaScript-from-local.html
* fast/loader/local-image-from-local.html

More info at but #81299
Comment 1 Manuel Rego Casasnovas 2013-01-22 03:22:53 PST
Also these 2 extra tests were failing due to the same issue:
* fast/dom/frame-loading-via-document-write.html (bug #64135)
* http/tests/security/local-user-CSS-from-remote.html (bug #95043)
Comment 2 Manuel Rego Casasnovas 2013-01-22 03:31:04 PST
Created attachment 183953 [details]
Patch
Comment 3 Martin Robinson 2013-01-28 07:35:09 PST
Comment on attachment 183953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183953&action=review

Nice work. This looks good to me. I have just pointed out a style nit below. If you like, I can fix this and land it or you can upload a new patch.

> Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:35
>  #include "InjectedBundle.h"
> +
> +#include "InjectedBundleUtilities.h"
> +
>  #include <glib.h>
> +#include <wtf/gobject/GOwnPtr.h>

Keep all these includes together as one solid block.
Comment 4 Manuel Rego Casasnovas 2013-01-28 07:37:28 PST
(In reply to comment #3)
> Nice work. This looks good to me. I have just pointed out a style nit below. If you like, I can fix this and land it or you can upload a new patch.

I'll fix the issue in a new patch. Thanks for the review :-)
Comment 5 Manuel Rego Casasnovas 2013-01-28 08:14:25 PST
Created attachment 184986 [details]
Patch
Comment 6 WebKit Review Bot 2013-01-28 08:46:07 PST
Comment on attachment 184986 [details]
Patch

Clearing flags on attachment: 184986

Committed r140970: <http://trac.webkit.org/changeset/140970>
Comment 7 WebKit Review Bot 2013-01-28 08:46:14 PST
All reviewed patches have been landed.  Closing bug.