QtWebKit(1) is missing an implementation tracking and calling the permission request callbacks when using Web Nofications in non-legacy mode.
Created attachment 183756 [details] Patch
Comment on attachment 183756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183756&action=review > Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:332 > +#if ENABLE(NOTIFICATIONS) > +void NotificationPresenterClientQt::requestPermission(ScriptExecutionContext* context, PassRefPtr<NotificationPermissionCallback> callback) > +{ This is pretty much duplicated code, could you factor out the common code of the two implementations in a separate method?
Created attachment 183768 [details] Patch
Comment on attachment 183756 [details] Patch Humm, it doesn't look as good as I thought, so we might as well duplicate the code. - NotificationPermissionCallback is defined behind ENABLE(NOTIFICATIONS) - Adding to a different list depending on the callback type isn't great r+ing the first one
Committed r140330: <http://trac.webkit.org/changeset/140330>