Bug 107158 – Add a version of the html-parser benchmark which uses srcdoc instead of document.write so it tests the threaded parser

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add a version of the html-parser benchmark which uses srcdoc instead of document.write so it tests the threaded parser

[Eric Seidel (no email)]

Created attachment 183245 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 183245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183245&action=review

> PerformanceTests/ChangeLog:11
> +        * Parser/html-parser-srcdoc.html: Added.

Please skip this test by default for now (add it to PerformanceTests/Skipped) since this test is a duplicate of html-parser.html.

> PerformanceTests/Parser/html-parser-srcdoc.html:16
> +PerfTestRunner.prepareToMeasureValuesAsync({iterationCount: 10, done: onCompletedRun, unit: 'ms'});

Please don't set iterationCount. We should just make 20 measurements.

[Ryosuke Niwa]

Comment on attachment 183245 [details]
Patch

r=me provided above changes.

[Adam Barth]

Comment on attachment 183245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183245&action=review

> PerformanceTests/Parser/html-parser-srcdoc.html:6
> +if (window.internals.settings.setThreadedHTMLParser)

Should we check for window.internals too so that we can run this test outside DumpRenderTree?

[Eric Seidel (no email)]

It's not an identical benchmark, I would expect it may get slightly different numbers, but I can add it to Skipped if you like.

I assume we'll still be able to run it with run-perf-tests even though it's "Skipped"?

[Ryosuke Niwa]

(In reply to comment #5)
> It's not an identical benchmark, I would expect it may get slightly different numbers, but I can add it to Skipped if you like.
> 
> I assume we'll still be able to run it with run-perf-tests even though it's "Skipped"?

Yes. Just pass --force.

[Eric Seidel (no email)]

Created attachment 183250 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 183250 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=183250&action=review

> PerformanceTests/Parser/html-parser-srcdoc.html:16
> +PerfTestRunner.prepareToMeasureValuesAsync({iterationCount: 10, done: onCompletedRun, unit: 'ms'});

Please remove iterationCount.

[Eric Seidel (no email)]

I don't know how the project functioned before "webkit-patch apply-from-bug". :)

[Eric Seidel (no email)]

Created attachment 183263 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 183263 [details]
Patch for landing

Clearing flags on attachment: 183263

Committed r140051: <http://trac.webkit.org/changeset/140051>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 107210

[Eric Seidel (no email)]

Created attachment 183347 [details]
Patch for landing

[Eric Seidel (no email)]

I skipped the file with the correct case now.  It should be ignored on win/linux as well as mac.

[WebKit Review Bot]

Comment on attachment 183347 [details]
Patch for landing

Rejecting attachment 183347 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
56>At revision 173055.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15946193

[Dominic Cooney]

Oops, based on comments in bug 107210 I relanded this with the correct case in r140088.