Bug 106970 - REGRESSION(r139792): Broke the windows build.
Summary: REGRESSION(r139792): Broke the windows build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 106904
  Show dependency tree / graph
 
Reported: 2013-01-15 18:37 PST by Levi Weintraub
Modified: 2013-01-15 19:00 PST (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r139792 (24.36 KB, patch)
2013-01-15 18:37 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2013-01-15 18:37:09 PST 
http://trac.webkit.org/changeset/139792 broke the build:
Broke the windows build.
Comment 1 Levi Weintraub 2013-01-15 18:37:26 PST 
Created attachment 182897 [details]
ROLLOUT of r139792

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Levi Weintraub 2013-01-15 18:40:31 PST 
Comment on attachment 182897 [details]
ROLLOUT of r139792

Clearing flags on attachment: 182897

Committed r139821: <http://trac.webkit.org/changeset/139821>
Comment 3 Levi Weintraub 2013-01-15 18:40:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 noel gordon 2013-01-15 19:00:12 PST 
e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1107) : error C2079: 'tempPath' uses undefined class 'WTF::OwnArrayPtr<T>'

        with

        [

            T=WCHAR

        ]

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1107) : error C3861: 'adoptArrayPtr': identifier not found

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1108) : error C2228: left of '.get' must have class/struct/union

        type is 'int'

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1111) : error C3861: 'adoptArrayPtr': identifier not found

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1112) : error C2228: left of '.get' must have class/struct/union

        type is 'int'

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1115) : error C2228: left of '.get' must have class/struct/union

        type is 'int'

e:\b\build\slave\win\build\src\third_party\webkit\tools\dumprendertree\chromium\webviewhost.cpp(1115) : error C2228: left of '.utf8' must have class/struct/union



ninja: build stopped: subcommand failed.