Bug 106904 - [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
Summary: [chromium] route more webkit_support and webviewhost callbacks through WebTes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on: 106970
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-15 07:12 PST by jochen
Modified: 2013-01-16 04:43 PST (History)
8 users (show)

See Also:


Attachments
Patch (24.76 KB, patch)
2013-01-15 07:13 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (24.78 KB, patch)
2013-01-15 07:29 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (24.78 KB, patch)
2013-01-15 07:36 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (24.78 KB, patch)
2013-01-15 07:41 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (24.88 KB, patch)
2013-01-15 13:49 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (25.04 KB, patch)
2013-01-16 03:57 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-15 07:12:44 PST
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
Comment 1 jochen 2013-01-15 07:13:21 PST
Created attachment 182760 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 07:16:25 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Peter Beverloo (cr-android ews) 2013-01-15 07:24:46 PST
Comment on attachment 182760 [details]
Patch

Attachment 182760 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15868896
Comment 4 jochen 2013-01-15 07:29:47 PST
Created attachment 182767 [details]
Patch
Comment 5 Peter Beverloo (cr-android ews) 2013-01-15 07:34:10 PST
Comment on attachment 182767 [details]
Patch

Attachment 182767 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15845959
Comment 6 jochen 2013-01-15 07:36:07 PST
Created attachment 182769 [details]
Patch
Comment 7 WebKit Review Bot 2013-01-15 07:37:43 PST
Attachment 182769 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/c..." exit_code: 1
Tools/DumpRenderTree/chromium/WebViewHost.cpp:73:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 jochen 2013-01-15 07:41:23 PST
Created attachment 182770 [details]
Patch
Comment 9 jochen 2013-01-15 13:49:33 PST
Created attachment 182842 [details]
Patch for landing
Comment 10 WebKit Review Bot 2013-01-15 14:23:10 PST
Comment on attachment 182842 [details]
Patch for landing

Clearing flags on attachment: 182842

Committed r139792: <http://trac.webkit.org/changeset/139792>
Comment 11 WebKit Review Bot 2013-01-15 14:23:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Levi Weintraub 2013-01-15 18:37:12 PST
Re-opened since this is blocked by bug 106970
Comment 13 jochen 2013-01-16 03:57:00 PST
Created attachment 182954 [details]
Patch
Comment 14 WebKit Review Bot 2013-01-16 04:43:12 PST
Comment on attachment 182954 [details]
Patch

Clearing flags on attachment: 182954

Committed r139872: <http://trac.webkit.org/changeset/139872>
Comment 15 WebKit Review Bot 2013-01-16 04:43:17 PST
All reviewed patches have been landed.  Closing bug.