Bug 106614 – [Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

This is a preparation for Bug 106283.

[Hajime Morrita]

Created attachment 182229 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 182229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182229&action=review

> Source/WebCore/ChangeLog:14
> +        - Introduces InsertionPoint::prematch() to give a chance each InsertionPoint to decide whether it

I don't like the word prematch. It doesn't convey the meaning here quite right. Can we treat this instead as a function to determine what kind of matching this insertion point uses:


MatchType {
AlwaysMatches
NeverMatches
HasToMatchSelector
}

[Hajime Morrita]

Created attachment 182242 [details]
Patch

[Hajime Morrita]

(In reply to comment #2)
> I don't like the word prematch. It doesn't convey the meaning here quite right. Can we treat this instead as a function to determine what kind of matching this insertion point uses:
Thanks for the insight! I didn't have good name here. Renamed.

[Dimitri Glazkov (Google)]

Comment on attachment 182242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182242&action=review

> Source/WebCore/html/shadow/InsertionPoint.h:54
> +        MatchAccept,
> +        MatchReject,
> +        MatchSelect

I kind of like the longer names that explain what's happening (the ones that I suggested).

[Hajime Morrita]

(In reply to comment #5)
> I kind of like the longer names that explain what's happening (the ones that I suggested).
OK, will take that way.

[Hajime Morrita]

Created attachment 182245 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182245 [details]
Patch for landing

Clearing flags on attachment: 182245

Committed r139400: <http://trac.webkit.org/changeset/139400>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.