Bug 106283 - [Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM
Summary: [Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 106614
Blocks: 103339
  Show dependency treegraph
 
Reported: 2013-01-07 17:54 PST by Hajime Morrita
Modified: 2013-01-10 23:40 PST (History)
12 users (show)

See Also:


Attachments
Patch (16.60 KB, patch)
2013-01-09 19:40 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (18.99 KB, patch)
2013-01-09 20:43 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (22.33 KB, patch)
2013-01-09 22:13 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (22.06 KB, patch)
2013-01-09 22:37 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (22.85 KB, patch)
2013-01-10 00:05 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (14.35 KB, patch)
2013-01-10 20:35 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (14.02 KB, patch)
2013-01-10 20:55 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (14.78 KB, patch)
2013-01-10 21:13 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (14.26 KB, patch)
2013-01-10 21:17 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-01-07 17:54:24 PST
Part of Bug 103339. This is easy one.
Comment 1 Hajime Morrita 2013-01-09 19:40:31 PST
Created attachment 182050 [details]
Patch
Comment 2 Build Bot 2013-01-09 20:07:03 PST
Comment on attachment 182050 [details]
Patch

Attachment 182050 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15764746
Comment 3 Build Bot 2013-01-09 20:18:48 PST
Comment on attachment 182050 [details]
Patch

Attachment 182050 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15757791
Comment 4 Hajime Morrita 2013-01-09 20:43:05 PST
Created attachment 182055 [details]
Patch
Comment 5 Build Bot 2013-01-09 20:57:04 PST
Comment on attachment 182055 [details]
Patch

Attachment 182055 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15757802
Comment 6 Build Bot 2013-01-09 21:14:33 PST
Comment on attachment 182055 [details]
Patch

Attachment 182055 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15756872
Comment 7 Hajime Morrita 2013-01-09 22:13:31 PST
Created attachment 182062 [details]
Patch
Comment 8 Build Bot 2013-01-09 22:17:19 PST
Comment on attachment 182062 [details]
Patch

Attachment 182062 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15795064
Comment 9 WebKit Review Bot 2013-01-09 22:17:58 PST
Comment on attachment 182062 [details]
Patch

Attachment 182062 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15755869
Comment 10 EFL EWS Bot 2013-01-09 22:18:38 PST
Comment on attachment 182062 [details]
Patch

Attachment 182062 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15766697
Comment 11 Peter Beverloo (cr-android ews) 2013-01-09 22:24:18 PST
Comment on attachment 182062 [details]
Patch

Attachment 182062 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15795065
Comment 12 Hajime Morrita 2013-01-09 22:37:25 PST
Created attachment 182069 [details]
Patch
Comment 13 Build Bot 2013-01-09 22:59:45 PST
Comment on attachment 182069 [details]
Patch

Attachment 182069 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15775652
Comment 14 Build Bot 2013-01-09 23:01:53 PST
Comment on attachment 182069 [details]
Patch

Attachment 182069 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15771828
Comment 15 Hajime Morrita 2013-01-10 00:05:52 PST
Created attachment 182078 [details]
Patch
Comment 16 Dimitri Glazkov (Google) 2013-01-10 09:45:09 PST
Comment on attachment 182078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182078&action=review

Can you split up the prematch code into a separate patch? Seems like it would make reviewing easier.

> Source/WebCore/ChangeLog:12
> +        even after this chagne. They are for minimizing #if/#endif usage

chagne -> change.
Comment 17 Hajime Morrita 2013-01-10 16:16:58 PST
(In reply to comment #16)
> (From update of attachment 182078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182078&action=review
> 
> Can you split up the prematch code into a separate patch? Seems like it would make reviewing easier.

Sure I should. Filed Bug 106614.
Comment 18 Hajime Morrita 2013-01-10 20:35:23 PST
Created attachment 182253 [details]
Patch
Comment 19 Build Bot 2013-01-10 20:39:11 PST
Comment on attachment 182253 [details]
Patch

Attachment 182253 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15801290
Comment 20 Hajime Morrita 2013-01-10 20:55:20 PST
Created attachment 182257 [details]
Patch
Comment 21 Build Bot 2013-01-10 20:59:27 PST
Comment on attachment 182257 [details]
Patch

Attachment 182257 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15795487
Comment 22 Early Warning System Bot 2013-01-10 21:04:41 PST
Comment on attachment 182257 [details]
Patch

Attachment 182257 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15804201
Comment 23 Early Warning System Bot 2013-01-10 21:07:19 PST
Comment on attachment 182257 [details]
Patch

Attachment 182257 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15811144
Comment 24 Build Bot 2013-01-10 21:13:37 PST
Comment on attachment 182257 [details]
Patch

Attachment 182257 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15801304
Comment 25 Hajime Morrita 2013-01-10 21:13:56 PST
Created attachment 182258 [details]
Patch
Comment 26 Hajime Morrita 2013-01-10 21:17:45 PST
Created attachment 182259 [details]
Patch
Comment 27 WebKit Review Bot 2013-01-10 23:40:47 PST
Comment on attachment 182259 [details]
Patch

Clearing flags on attachment: 182259

Committed r139410: <http://trac.webkit.org/changeset/139410>
Comment 28 WebKit Review Bot 2013-01-10 23:40:55 PST
All reviewed patches have been landed.  Closing bug.