WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106283
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM
https://bugs.webkit.org/show_bug.cgi?id=106283
Summary
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW...
Hajime Morrita
Reported
2013-01-07 17:54:24 PST
Part of
Bug 103339
. This is easy one.
Attachments
Patch
(16.60 KB, patch)
2013-01-09 19:40 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(18.99 KB, patch)
2013-01-09 20:43 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(22.33 KB, patch)
2013-01-09 22:13 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(22.06 KB, patch)
2013-01-09 22:37 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(22.85 KB, patch)
2013-01-10 00:05 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(14.35 KB, patch)
2013-01-10 20:35 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(14.02 KB, patch)
2013-01-10 20:55 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(14.78 KB, patch)
2013-01-10 21:13 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch
(14.26 KB, patch)
2013-01-10 21:17 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(8)
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2013-01-09 19:40:31 PST
Created
attachment 182050
[details]
Patch
Build Bot
Comment 2
2013-01-09 20:07:03 PST
Comment on
attachment 182050
[details]
Patch
Attachment 182050
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/15764746
Build Bot
Comment 3
2013-01-09 20:18:48 PST
Comment on
attachment 182050
[details]
Patch
Attachment 182050
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15757791
Hajime Morrita
Comment 4
2013-01-09 20:43:05 PST
Created
attachment 182055
[details]
Patch
Build Bot
Comment 5
2013-01-09 20:57:04 PST
Comment on
attachment 182055
[details]
Patch
Attachment 182055
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/15757802
Build Bot
Comment 6
2013-01-09 21:14:33 PST
Comment on
attachment 182055
[details]
Patch
Attachment 182055
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15756872
Hajime Morrita
Comment 7
2013-01-09 22:13:31 PST
Created
attachment 182062
[details]
Patch
Build Bot
Comment 8
2013-01-09 22:17:19 PST
Comment on
attachment 182062
[details]
Patch
Attachment 182062
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15795064
WebKit Review Bot
Comment 9
2013-01-09 22:17:58 PST
Comment on
attachment 182062
[details]
Patch
Attachment 182062
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/15755869
EFL EWS Bot
Comment 10
2013-01-09 22:18:38 PST
Comment on
attachment 182062
[details]
Patch
Attachment 182062
[details]
did not pass efl-ews (efl): Output:
http://queues.webkit.org/results/15766697
Peter Beverloo (cr-android ews)
Comment 11
2013-01-09 22:24:18 PST
Comment on
attachment 182062
[details]
Patch
Attachment 182062
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/15795065
Hajime Morrita
Comment 12
2013-01-09 22:37:25 PST
Created
attachment 182069
[details]
Patch
Build Bot
Comment 13
2013-01-09 22:59:45 PST
Comment on
attachment 182069
[details]
Patch
Attachment 182069
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15775652
Build Bot
Comment 14
2013-01-09 23:01:53 PST
Comment on
attachment 182069
[details]
Patch
Attachment 182069
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/15771828
Hajime Morrita
Comment 15
2013-01-10 00:05:52 PST
Created
attachment 182078
[details]
Patch
Dimitri Glazkov (Google)
Comment 16
2013-01-10 09:45:09 PST
Comment on
attachment 182078
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=182078&action=review
Can you split up the prematch code into a separate patch? Seems like it would make reviewing easier.
> Source/WebCore/ChangeLog:12 > + even after this chagne. They are for minimizing #if/#endif usage
chagne -> change.
Hajime Morrita
Comment 17
2013-01-10 16:16:58 PST
(In reply to
comment #16
)
> (From update of
attachment 182078
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=182078&action=review
> > Can you split up the prematch code into a separate patch? Seems like it would make reviewing easier.
Sure I should. Filed
Bug 106614
.
Hajime Morrita
Comment 18
2013-01-10 20:35:23 PST
Created
attachment 182253
[details]
Patch
Build Bot
Comment 19
2013-01-10 20:39:11 PST
Comment on
attachment 182253
[details]
Patch
Attachment 182253
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15801290
Hajime Morrita
Comment 20
2013-01-10 20:55:20 PST
Created
attachment 182257
[details]
Patch
Build Bot
Comment 21
2013-01-10 20:59:27 PST
Comment on
attachment 182257
[details]
Patch
Attachment 182257
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15795487
Early Warning System Bot
Comment 22
2013-01-10 21:04:41 PST
Comment on
attachment 182257
[details]
Patch
Attachment 182257
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/15804201
Early Warning System Bot
Comment 23
2013-01-10 21:07:19 PST
Comment on
attachment 182257
[details]
Patch
Attachment 182257
[details]
did not pass qt-wk2-ews (qt): Output:
http://queues.webkit.org/results/15811144
Build Bot
Comment 24
2013-01-10 21:13:37 PST
Comment on
attachment 182257
[details]
Patch
Attachment 182257
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/15801304
Hajime Morrita
Comment 25
2013-01-10 21:13:56 PST
Created
attachment 182258
[details]
Patch
Hajime Morrita
Comment 26
2013-01-10 21:17:45 PST
Created
attachment 182259
[details]
Patch
WebKit Review Bot
Comment 27
2013-01-10 23:40:47 PST
Comment on
attachment 182259
[details]
Patch Clearing flags on attachment: 182259 Committed
r139410
: <
http://trac.webkit.org/changeset/139410
>
WebKit Review Bot
Comment 28
2013-01-10 23:40:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug