Bug 106504 - REGRESSION(r139189): pixel alignment must be performed in device units.
Summary: REGRESSION(r139189): pixel alignment must be performed in device units.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on: 106355 106499
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-09 16:53 PST by Dongseong Hwang
Modified: 2013-01-10 02:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2013-01-09 16:59 PST, Dongseong Hwang 		kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2013-01-10 00:52 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-09 16:53:17 PST 
After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is
fractional number, adjusted scroll position can blur non-composited layer.
Comment 1 Dongseong Hwang 2013-01-09 16:59:19 PST 
Created attachment 182016 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2013-01-09 19:14:25 PST 
Comment on attachment 182016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182016&action=review

> Source/WebKit2/UIProcess/PageViewportController.cpp:98
> +    float contentsScale = m_pageScaleFactor * deviceScaleFactor();

lets call this effectiveScale
Comment 3 Dongseong Hwang 2013-01-10 00:52:55 PST 
Created attachment 182082 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-10 02:01:09 PST 
Comment on attachment 182082 [details]
Patch

Clearing flags on attachment: 182082

Committed r139300: <http://trac.webkit.org/changeset/139300>
Comment 5 WebKit Review Bot 2013-01-10 02:01:13 PST 
All reviewed patches have been landed.  Closing bug.