Bug 106499 - [QT][EFL][WK2] Rename scale members in PageViewportController.
Summary: [QT][EFL][WK2] Rename scale members in PageViewportController.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on: 106355
Blocks: 106504 106512 106537
  Show dependency tree / graph
 
Reported: 2013-01-09 16:21 PST by Dongseong Hwang
Modified: 2013-01-10 01:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.94 KB, patch)
2013-01-09 16:22 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (15.91 KB, patch)
2013-01-09 16:40 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2013-01-09 16:44 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-09 16:21:35 PST 
Rename from m_contentsScale to m_pageScaleFactor and from devicePixelRatio() to deviceScaleFactor() to match terms of WebCore.
Comment 1 Dongseong Hwang 2013-01-09 16:22:53 PST 
Created attachment 182005 [details]
Patch
Comment 2 Early Warning System Bot 2013-01-09 16:33:17 PST 
Comment on attachment 182005 [details]
Patch

Attachment 182005 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15756790
Comment 3 Dongseong Hwang 2013-01-09 16:40:17 PST 
Created attachment 182010 [details]
Patch
Comment 4 Dongseong Hwang 2013-01-09 16:44:44 PST 
Created attachment 182014 [details]
Patch
Comment 5 WebKit Review Bot 2013-01-09 19:12:57 PST 
Comment on attachment 182014 [details]
Patch

Clearing flags on attachment: 182014

Committed r139274: <http://trac.webkit.org/changeset/139274>
Comment 6 WebKit Review Bot 2013-01-09 19:13:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Benjamin Poulain 2013-01-09 19:19:26 PST 
Comment on attachment 182014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182014&action=review

> Source/WebKit2/UIProcess/PageViewportController.h:71
>      float minimumContentsScale() const { return m_minimumScaleToFit; }
>      float maximumContentsScale() const { return m_rawAttributes.maximumScale; }
> -    float currentContentsScale() const { return m_contentsScale; }
> +    float currentContentsScale() const { return m_pageScaleFactor; }

Wait what?
Why do you keep names mixed here?
Comment 8 Dongseong Hwang 2013-01-09 19:42:37 PST 
(In reply to comment #7)
> (From update of attachment 182014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182014&action=review
> 
> > Source/WebKit2/UIProcess/PageViewportController.h:71
> >      float minimumContentsScale() const { return m_minimumScaleToFit; }
> >      float maximumContentsScale() const { return m_rawAttributes.maximumScale; }
> > -    float currentContentsScale() const { return m_contentsScale; }
> > +    float currentContentsScale() const { return m_pageScaleFactor; }
> 
> Wait what?
> Why do you keep names mixed here?

Good point. Those methods are used by qt test code.
I'll change xxxScale instead of xxxContentsScale.
Comment 9 Dongseong Hwang 2013-01-10 01:03:12 PST 
(In reply to comment #7)
> (From update of attachment 182014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182014&action=review
> 
> > Source/WebKit2/UIProcess/PageViewportController.h:71
> >      float minimumContentsScale() const { return m_minimumScaleToFit; }
> >      float maximumContentsScale() const { return m_rawAttributes.maximumScale; }
> > -    float currentContentsScale() const { return m_contentsScale; }
> > +    float currentContentsScale() const { return m_pageScaleFactor; }
> 
> Wait what?
> Why do you keep names mixed here?

I fixed in Bug 106537.