Bug 106408 – Change semantics of subtracting one Int/FloatPoint from another

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Steve Block]

Change semantics of subtracting one Int/FloatPoint from another

[Steve Block]

The common case of subtracting one Int/FloatPoint from another is to obtain a relative position or vector, so this should be supported by operator-().  Creating an Int/FloatSize from two Int/FloatPoints is a less common operation and should be made more explicit.

I therefore propose that we ...
- remove 'Int/FloatSize operator-(const int/FloatPoint&, const Int/FloatPoint&)'
- add 'Int/FloatPoint operator-(const int/FloatPoint&, const Int/FloatPoint&)'
- add 'Int/FloatSize Int/FloatSize::fromCornerPoints(const int/FloatPoint&, const Int/FloatPoint&)'

[Steve Block]

Created attachment 181826 [details]
Patch

[Steve Block]

Patch for initial comments. A few things to note ...
- Adding 'FloatPoint::distance(Squared)ToPoint(const FloatPoint&)' can be done in a prerequisite patch - https://bugs.webkit.org/show_bug.cgi?id=105995
- The XCode project file needs updating
- I can move more implementation to the new IntSize.cpp

I'll wait for initial feedback before addressing these things.

[Early Warning System Bot]

Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15758372

[Early Warning System Bot]

Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15775188

[Build Bot]

Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15774198

[Build Bot]

Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15766269

[EFL EWS Bot]

Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15766309

[Steve Block]

Created attachment 181846 [details]
Patch

[Early Warning System Bot]

Comment on attachment 181846 [details]
Patch

Attachment 181846 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15763395

[EFL EWS Bot]

Comment on attachment 181846 [details]
Patch

Attachment 181846 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15760368

[Steve Block]

Created attachment 181854 [details]
Patch

[Build Bot]

Comment on attachment 181854 [details]
Patch

Attachment 181854 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15764374

[Build Bot]

Comment on attachment 181854 [details]
Patch

Attachment 181854 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15756491

[Steve Block]

Created attachment 182003 [details]
Patch

[Build Bot]

Comment on attachment 182003 [details]
Patch

Attachment 182003 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15759738

[Steve Block]

It seems there ins't the required level of support for this change. See http://lists.webkit.org/pipermail/webkit-dev/2013-January/023212.html